jcplessis / pyconcordion_failedimport Goto Github PK

Please update to Concordion 1.4.1.

As an enhancement it would be very nice to be able to use the 
concordion-extensions package with our Python tests.

The default output directory under windows is C:\tmp, should be C:\Temp or even 
better, the operating system temporary folder.

It should be nice to have an option to be used like :
`concordion_folder_runner --output_directory=/tmp/myDirectory my_test_folder`

This option would override default value from configuration file.

I must be missing something obvious, but having run a couple of tests with:
python concordion_folder_runner.py c:\tmp\conc, where is the html results 
summary ?

Also, note that the documentation says to run 'folder_runner.py'.  After 
setup.py I found concordion_folder_runner (with no '.py') and no 
'folder_runner.py'.

Thanks,
JC

concordion:verifyRows will not work since you cast to String in 
"src/concordion/impl/java.py", but it requires an iterable I hacked
together some code to make it work but I
don't program java so I think it could be done better:

public Object %(name)s(%(args_declaration)s) throws XmlRpcException{
    Object object = this.client.execute("%(name)s", new
Object[]{%(args_list)s});
    try{
    List list = Arrays.asList((Object[]) object);
    return list;
    }catch(Exception e){
    String string = (String) object;
    return string;
    }
}"""

Having 2 tests, when the first one is a failling test, the second one is
not executed, thus we don't know the result.

This would add assertTrue, we should also add the annotations :
   * @ExpectedToPass
   * @ExpectedToFail
   * @Unimplemented

There is no lib folder in 0.6 at all, is it intentional? 

I see the following warning upon installation, furthermore the --prefix is not 
handled as expected since it installs the data_files into $PREFIX/usr/bin 
instead of $PREFIX/bin.

Patch below fixes both issues.

Index: src/setup.py
===================================================================
--- src/setup.py    (revision 89)
+++ src/setup.py    (working copy)
@@ -10,5 +10,5 @@ setup(name='PyConcordion',
       packages=['concordion', 'concordion.impl'],
       package_data={'concordion': ['*.ini', 'lib/*.jar']},
       scripts=['scripts/concordion_folder_runner', ],
-      data_file=[('/usr/bin/', ['scripts/concordion_folder_runner'])]
+      data_files=[('bin/', ['scripts/concordion_folder_runner'])]
 )

As an enhancement it would be nice to add an annotation, or some other 
mechanism, so the test fixture knows how to convert inputs to the proper types. 
 For example,

@testmethod('str', 'str', 'int', 'bool')
def myTestMethod(self, myStr, myInt, myBool):
    ...
    return someStr

Would tell the Concordion fixture to expect a string return value and convert 
the inputs to string, int, and boolean respectively.

What steps will reproduce the problem?
1. If I have something like:

<a concordion:run="concordion" href="Foo.html">Test 1</a> inside a test called 
Index.html it will not run.


What is the expected output? What do you see instead?
Index.html should then run the individual tests.

What version of the product are you using? On what operating system?
Latest version of pyconcordion. Tested on Windows and Redhat


Please provide any additional information below.

Forgive me if I'm not running unittest correctly, but I tried running the unit 
tests under python2.7 on windows xp from the command line:
python -m unittest discover -s . -p "*_test.py"

I got 

Ran 14 tests in 1.140s

FAILED (failures=5, errors=3)

Is this because I am running tests the wrong way, or because they don't pass 
currently?

thanks

(very new to unittest)

There is a typo in the ArrayExample testcase: it says "dsomething" instead of 
"something".

Index: examples/dataTypes/ArrayExample.html
===================================================================
--- examples/dataTypes/ArrayExample.html    (revision 89)
+++ examples/dataTypes/ArrayExample.html    (working copy)
@@ -12,7 +12,7 @@
         <h3>Example</h3>

        <p>This test prooves usage of concordion:execute, concordion:set and concordion:verifyRows works with PyConcordion.</p>
-       <p>One constraint is that no method in the fixture returns None, so even the 
addUser method returns dsomething (i.e. :"ok")</p>
+       <p>One constraint is that no method in the fixture returns None, so even the 
addUser method returns something (i.e. :"ok")</p>

        We add those users :
        <table concordion:execute="addUser(#username)">