float32 values corrupted in firefox after reading a uint16 about jdataview HOT 9 CLOSED

I forgot to write that the endian value must be set to true, also, after tracing, the error seems to happen when "the alignment is not good" and the value is read using "value = this['_get' + type](this._start + byteOffset, littleEndian);". After testing with a change of bit order, I conclude that the problem happens in the _getFloat32 function whatever endianness is used.

from jdataview.

To correct the bug, change these 3 variables' assignment in the _getFloat32 method :

sign = 1 - (2 * ((b0 >> 7) & 0x01)),
exponent = (((b0 << 1) & 0x00fe) | ((b1 >> 7) & 0x01)) - 127,
mantissa = ((b1 << 16) & 0x7F0000) | ((b2 << 8) & 0xFF00) | b3;

from jdataview.

I am in an exam week, will check this out tomorrow. Thanks for locating the issue, it'll help to fix it.

from jdataview.

The changes you made seem weird.

I borrowed the conversion code from Three.js, I believe there are no errors there ...
https://github.com/mrdoob/three.js/blob/master/src/extras/io/BinaryLoader.js

from jdataview.

https://github.com/vjeux/jsDataView/commit/66a523fcd285e9e5d8db51dc724b7f029b0df255

I made a commit to fix some issues. This is partially fixing your bug.

from jdataview.

http://en.wikipedia.org/wiki/IEEE_754-1985

Ok! This is not the same value because of denormalized numbers. Have to go to sleep, will fix it tomorrow :)

from jdataview.

I didn't test extensively the changes I made but at least, the simple mesh I tried to load using the modified script loaded right. It's a bit sad though that this code end up being used sometimes by chrome inside a web worker since the dataview isn't available in that context. Good luck with your exams!

Ps : Oups, I hit the close option and don't know how to cancel it...

from jdataview.

I have made some updates, can you retest please?

Note: I changed littleEndian to be set to TRUE by default. Because x86 architecture is littleEndian, all the files we have to deal with are in littleEndian. I have added a last argument to the jDataView constructor to set the default behavior of littleEndian.

new jDataView(buffer, undefined, undefined, false)
to get the original behavior.

from jdataview.

Seems to be working great! I'll close the issue.

Thank you.

from jdataview.