jeeeyul / swtend Goto Github PK

Hey Jeeeyul!
First, I would to thank you for amazing job you do with themes support!

I have recently noticed a slow rendering when your eclipse theme is active. Debugging some other issue I have noticed that you are using Jobs to dispose some temporary SWT resources (like Path). The problem here is that to be able to schedule a job, manager has to enter a lock, and it is possible that UI thread will have to wait some time to enter it. If there is big job activity, especially during startup, drawing might be very slow, as it has to wait to acquire lock.

Therefore, I think that usage of Jobs in UI during drawing is not too good. I think that usage of Display.timerExec, a Timer object, or a separate thread should be considered, or possibly a completly different approach to creation of temporary resources. Let me know what you think! I can prepare a PR if you don't have time to fix this.