jeffbeltran / sanctum-tokens Goto Github PK

Now (in ToolServiceProvider.php):

if (
    $this->app->routesAreCached() ||
    false === config("sanctum.routes")
) {
    return;
}

Should be:

if ($this->app->routesAreCached()) {
    return;
}

I'd like to be able to have the plugin routes without including Sanctum ones.

Hello Jeff,
Your package is great.
I would like to ask you if you can make the Abilities field on the creation form hidden and maybe with default value.
Thank you for your work,
Theofanis

Hi! thanks in advance for this cool package and for the hard work.

I've trying to use it but seems like its having some issues:

Once i'm on the User resource and after inserting
SanctumTokens::make()

When i'm on the detail page and after creating a token, nothing gets displayed while i get a js error on the console:
TypeError: Cannot read properties of undefined (reading 'length') even when the token has been successfully created.

I'm on Laravel 8, Laravel Nova 4 and latest sanctum-tokens.

Looking forward to hear from you! Thanks again.

With Laravel 9, translation files are now by default located outside of the resources directory, directly under the project root folder.

If we move the published translation file to that location, then the strings do not appear translated.

Additionally, it would be nice to publish the translation file there instead of resources/lang.

Hi,

Thanks for the package.
I get TypeError: Cannot read property 'options' of undefined when I click on Create token in Nova.

I also use Eminiarts/Tabs if that can help.

Please advise. Thanks

Hi,

The token name is required, but the dialogue allows to enter the empty name.

When you enter the empty value:

Argument 1 passed to ...Models\\User::createToken() must be of the type string, null given, called in /app/vendor/jeffbeltran/sanctum-tokens/src/Http/SanctumController.php on line 27

A simple workaround is re-defining the createToken as:

    /**
     * Create a new personal access token for the user.
     *
     * @param  string  $name
     * @param  array  $abilities
     * @return \Laravel\Sanctum\NewAccessToken
     */
    public function createToken_d(?string $name = null, array $abilities = ['*'])
    {
        if (!$name) {
            $name = '- Empty Name -';
        }

        $token = $this->tokens()->create([
            'name' => $name,
            'token' => hash('sha256', $plainTextToken = Str::random(40)),
            'abilities' => $abilities,
        ]);

        return new NewAccessToken($token, $token->getKey().'|'.$plainTextToken);
    }

Clicking the button does nothing.

Conversation here: laravel/nova-issues#6025

Currently the package assumes App\User is the user entity, breaking when we customize such class or namespace.

Would be great to be able to customize this through configuration.

Currently there is a "hacky" workaround though, in case it helps someone:

Hi this seems a cool little package and could be just what I need, but I am concerned that there seems to be no authorisation in place to control who can create (or indeed revoke) a token.

It looks like with a bit of messing around with the HTTP request in Nova any user could create or revoke a token for any other user.

Have I got this wrong?

It would be great to have an option to only allow the ui to tick from a fixed list of authorisations/privileges rathe than a free type field.

it could be an optional method so the default behaviour stays as is.

would you be interested in this?

Hi,

All routes are defined with clousures. So, artisan optimize or artisan route:cache can't be executed.

What do you recommend to solve the issue? Is it something that can be improved?

Is it possible to edit abilities after creating a token?

Hey
It will be nice to have a the nova suggestion option on the tool.
This will be handy when you have a lot of abilities to choose from. The suggestion() method leverage the native html datalist element to provide a recommended options available to choose.
Thanks for your help here and for the great package.

Hello,

token in modal looks like this:

and after clicking, there is info that I can copy by click, but nothing happens after clicking.

I have newest version of Laravel and Nova, without any special Laravel Nova plugins. Bug occurs on every browser.

On Laravel Nova user resource we also see login tonkes that are generated on user login.

Is there a way to hide that? We would only like user to see tokens manually added by him.

Hi Jeff!

I'm Enrique and currently I'm using your package and it's very useful, thanks!. However it's necessary to be able to change language of all texts. There are some components that has hardcoded text:

So I would like to know if you can make a feature to add the internationalization?.

Thanks for your help!. I'll be waiting for your answer.