jeffkay16 / capstone-project Goto Github PK

Jeff, thanks for presenting your code, it's very neat and clean, I personally took several notes that I will be using in my later projects. In addition, we would like to share with you several suggestions and techniques:

1. In order to keep our main navbar in the main focus we would suggest wrapping this nav content inside the <aside> tag so that SEO searches focus on your main navigation lists.
2. According to Html best practices it will be good if your <main> tag wraps the whole content of the page, and not only the headline section.
3. According to Html best practices we should use only one <h1> tag per page, kindly have a look at that too.
4. Try not to import any files to your CSS file, since it prevents the page to load smoothly, instead, you could attach the same file into your HTML file inside the <meta> tags.
5. Sometimes we use the same color in our page over and over again, CSS provides a great way to avoid repeating our code. Instead of resigning the same color to different elements of your page, you could create a CSS variable and use it as many times as you need it, so that in case you will need to change the color of your elements, you will just need to change that color value in your variable and then the rest will be updated automatically.
6. The same practice could be applied to the repetitive height values on your page.
7. For the sake of page efficiency and DRY it will be good if you create just one JS file for your pages, in case some code applies just to certain pages you could include that in your javascript code as well.
8. It is preferable that our pages look good for different screen sizes, we would suggest starting your media queries from the screen size of 768 pixels.

Keep up the good work! We wish you success and happy coding!