jellyfin / jellyfin-build Goto Github PK

ffmpeg build failed due to host not having mmv.

I don't see jellyfin listed in Ubuntu's 20.04 repository. Can we get that added?

Hi folks,

when you upgrade jellyfin and do not reboot before doing any action (stop, start, reload) on the jellyfin systemd unit, systemd will complain that the unit file (or one of the unit's drop-ins) has been changed and systemd should be reloaded

A /bin/systemctl --system daemon-reload in the postinst of the control part of the package should fix this.

Sorry, if this is not the correct repository - just point me to the correct one instead :)

Cheers & thanks
Thomas

A while ago the build file was renamed to build.sh in the Android TV repository.

A bit later the Amazon and Google specific flavors were removed and we only have a single universal flavor now.

The first change needs changes in the build repository, I'm not really sure about the second one.

Using hadelint against the main dockerfile, gives the following results:

/dev/stdin:6 DL3003 Use WORKDIR to switch to a directory
/dev/stdin:6 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
/dev/stdin:6 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
/dev/stdin:6 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
/dev/stdin:33 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`

Posting here for reference later

Easy to use command docker run --rm -i hadolint/hadolint < Dockerfile

It has been discussed in multiple issues that our official Docker images do not fully support Intel Quick Sync on recent chipsets because non-free drivers are required. We were concerned about their licensing and therefore refrained from including those packages.

Since nobody on the team nor anyone in the issues was willing to take the time to check all licenses we persisted in not redistributing them.

I took the time to actually check all licenses of the packages and their source repos and check if they allow redistribution:

All used licenses explicitly allow redistribution in binary form if the license is provided (which Debian does in their packages).

There shouldn't be any problems for us including those packages in our images.

Edit:
intel-opencl-icd should not be used until this commit is included in the Debian package. Until then we need to explicitly install the official .debs from intel/compute-runtime

Comment by @nyanmisaka: If we decide to include the non-free driver, we should uncomment these lines in the jellyfin-ffmpeg build script and add the license to debian/copyright. Using old drivers from debian/ubuntu repo will miss many fixes and improvements for newer chips.

Ideally this changes are required:

• uncomment the ffmpeg lines to automatically build and ship the nonfree driver with our ffmpeg package
• use the latest .debs from intel/compute-runtime instead of old distro packages

Updated Dockerfile for Jellyfin: gist
Bash script to manually build and install the nonfree driver: gist

If I missed any required packages feel free to comment and I'll check them too.