Publish to JCenter about jellyfin-sdk-kotlin HOT 13 CLOSED

As @dkanada pointed out on Riot, we should stick to a repository that is supported by F-Droid. Refs: https://gitlab.com/fdroid/fdroidserver/blob/master/fdroidserver/scanner.py#L99

from jellyfin-sdk-kotlin.

The project can be added as a dependency from jitpack currently. It may still be worthwhile to publish somewhere else where we have more control over the build process in the future.

from jellyfin-sdk-kotlin.

https://bintray.com/jellyfin 👀

from jellyfin-sdk-kotlin.

Can't seem to get the source for this when trying to build the androidtv repo:

FAILURE: Build failed with an exception.

• What went wrong:
  Could not determine the dependencies of task ':app:compileGoogleReleaseAidl'.

Could not resolve all task dependencies for configuration ':app:googleReleaseCompileClasspath'.
Could not find com.github.jellyfin.jellyfin-apiclient-java:android:master-SNAPSHOT.
Required by:
project :app > com.github.jellyfin:jellyfin-apiclient-java:master-SNAPSHOT:77043c2709-1
Could not find com.github.jellyfin.jellyfin-apiclient-java:library:master-SNAPSHOT.
Required by:
project :app > com.github.jellyfin:jellyfin-apiclient-java:master-SNAPSHOT:77043c2709-1

from jellyfin-sdk-kotlin.

https://jitpack.io/com/github/jellyfin/jellyfin-apiclient-java/library/master-90a2e85952-1/library-master-77043c2709-1.pom

Build failed. See the log at jitpack.io

from jellyfin-sdk-kotlin.

It's really hard to contribute if we're referencing snapshots and the repositories are not compilable.
I'd recommend to reference a release version instead of snapshots.

Joao

from jellyfin-sdk-kotlin.

Bumping this to give it some attention. Would be cool if we can use versioning and a proper repository for the library.

from jellyfin-sdk-kotlin.

I did try to add versioning, but it was said that it was only wanted for releases, so that one TV release is one bump in apiclient version.

from jellyfin-sdk-kotlin.

That's not the case, we are just in a somewhat nebulous state because this API client is more of a placeholder until we can get at least most of the functionality generated from a specification. We could always add versioning now though.

from jellyfin-sdk-kotlin.

Hmm I remember distinctly being told to undo the version bump and reference master-snapshot again. Currently on mobile though, so I can't look up the link.

from jellyfin-sdk-kotlin.

Otoh, doesn't matter, I appreciate versioning as well

from jellyfin-sdk-kotlin.

The current release (on Github) is actually called 0.4.0. I will create a PR to set a version and use 0.5.0 so we can actually publish a new version (4 commits since 0.4.0).

edit: It seems like the current version is already set to 0.4.0 so in theory this could be published already.
edit2: We actually did use versions properly until recently when the library was updated. We switched to using the master branch at that time in the androidtv repository. We should probably create a separate issue to discuss versioning and keep this one for publishing to jcenter or similar

from jellyfin-sdk-kotlin.

Ok so what we want to avoid is having to constantly bump versions here and in Android TV during development. That is why the initial versioning that was added needed to be reverted.

For Android TV there is now a release branch that will use a specific release of this library. That allows the master branch of Android TV to track the master branch of the apiclient. Otherwise we would be constantly bumping versions while making changes here.

from jellyfin-sdk-kotlin.