Giter VIP home page Giter VIP logo

Comments (6)

nielsvanvelzen avatar nielsvanvelzen commented on July 4, 2024 1

Yes. We have a lot of issue reports for our clients caused by SSL issues. Right no we don't detect those in the SDK which isn't helpful. I'd like to have a single RecommendedServerIssue for all SSL related issues with more detail in it's body (e.g. the exception that caused it, maybe an enum with the type of SSL error).

The NoConnection one is also still nice to have.

from jellyfin-sdk-kotlin.

nielsvanvelzen avatar nielsvanvelzen commented on July 4, 2024 1

Yes they should be separate, one for SSL related issues and one for no connection. Maybe name it something like "UnsupportedSSL"? Since it's not necessarily a bad connection.

from jellyfin-sdk-kotlin.

alialiusefi avatar alialiusefi commented on July 4, 2024

Hi! Is this issue still actual? I would like to work on this if you dont mind

from jellyfin-sdk-kotlin.

alialiusefi avatar alialiusefi commented on July 4, 2024

Ok. I will look into the code and familarize myself with the api client.

from jellyfin-sdk-kotlin.

alialiusefi avatar alialiusefi commented on July 4, 2024

Hi! What do you think of naming the new RecommentedServerIssue implementation for SSL Errors as BadConnection? IMO, NoConnection is a bit misleading.

BadConnection implies we reached the server but the server/client aborted the connection (e.g SSL configuration error or just a timeout).
NoConnection implies we didn't reach the server at all (e.g. Cannot resolve url).

Regardless of the naming -> I will try to map ssl errors thrown by OkHttp due to SSL and add that to the new implementation class.

from jellyfin-sdk-kotlin.

alialiusefi avatar alialiusefi commented on July 4, 2024

Hi! Sorry for the delay, I created a pull request with required feature. I'm still thinking on how to approach testing this...

from jellyfin-sdk-kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.