Comments (6)
Yes. We have a lot of issue reports for our clients caused by SSL issues. Right no we don't detect those in the SDK which isn't helpful. I'd like to have a single RecommendedServerIssue for all SSL related issues with more detail in it's body (e.g. the exception that caused it, maybe an enum with the type of SSL error).
The NoConnection one is also still nice to have.
from jellyfin-sdk-kotlin.
Yes they should be separate, one for SSL related issues and one for no connection. Maybe name it something like "UnsupportedSSL"? Since it's not necessarily a bad connection.
from jellyfin-sdk-kotlin.
Hi! Is this issue still actual? I would like to work on this if you dont mind
from jellyfin-sdk-kotlin.
Ok. I will look into the code and familarize myself with the api client.
from jellyfin-sdk-kotlin.
Hi! What do you think of naming the new RecommentedServerIssue implementation for SSL Errors as BadConnection? IMO, NoConnection is a bit misleading.
BadConnection implies we reached the server but the server/client aborted the connection (e.g SSL configuration error or just a timeout).
NoConnection implies we didn't reach the server at all (e.g. Cannot resolve url).
Regardless of the naming -> I will try to map ssl errors thrown by OkHttp due to SSL and add that to the new implementation class.
from jellyfin-sdk-kotlin.
Hi! Sorry for the delay, I created a pull request with required feature. I'm still thinking on how to approach testing this...
from jellyfin-sdk-kotlin.
Related Issues (20)
- Testing with Robolectric HOT 2
- SSL errors not caught HOT 2
- Add data classes for requests with a lot of parameters HOT 1
- Discovery crashes with invalid port
- how to understand the docs for Jellyfin API HOT 2
- Follow index redirect in discovery HOT 4
- Is permission READ_EXTERNAL_STORAGE required? HOT 1
- Logo doesn't work in documentation with light theme
- TranscodingInfo.TranscodeReasons incorrectly generated HOT 1
- NoClassDefFoundError on API 23 HOT 2
- JsonDecodingException: TranscodeReasons is not a string HOT 5
- Automatically add labels to openapi update pull requests
- Send Message is not getting received on android HOT 4
- Use Duration instead of Long in HttpClientOptions
- Follow HTTP redirect when discovering servers HOT 3
- Reconnect behaviour HOT 3
- Dependency Dashboard
- Two endpoints called every hours HOT 1
- Optimize RegEx validation pattern usage
- SocketInstance / ReconnectHelper can get stuck disconnected HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jellyfin-sdk-kotlin.