jen4web / fem-adv-css-layout Goto Github PK

The media queries are missing the targeting of :root, which is where the variables are scoped at the top of the CSS file.

In the videos (2nd video, "Custom Properties Type Scale", at ~10:22), we see:

@media (min-width: 480px) {
  --base-size: 1.15em;
}

But instead, it should be:

@media (min-width: 480px) {
  :root {
    --base-size: 1.15em;
  }
}

Although the demo code does include the transition effect for the sidebar menu, it doesn't get used in a way that animates the menu when it appears or disappears.

There are mistakes in the pdf on page 7.
before:
.col-2-7{
width:calc(100%/2* 7);
}
.col-3-7{
width:calc(100%/3*7);
}
after(correct):
.col-2-7{
width:calc(100% * 2 / 7);
}
.col-3-7{
width:calc(100% * 3 / 7);
}

Exercise 2 and further exercises in each index.html