The glyphspkg from jenskutilek

"--output" arg seems to incorrectly nest output filepath

First, thank you for making this library! It is already proving to be so helpful, especially in a Makefile similar to your recommendation.

However, I think I may have come across an unintended result, so I wanted to report it.

Context:

I have an input, sources/shantellsans-wght_ital_IRGL.glyphspackage
I want an output to go into a build-prep folder
Therefore, I am adding the arg -o sources/build-prep/shantellsans-wght_ital_IRGL.glyphs

Unexpected result:

glyphspkg seems to want to nest the provided output path into the default path, like: fontdir/familyname.glyphs/familyname.glyphs

Here’s the full traceback:

▶ glyphspkg sources/shantellsans-wght_ital_IRGL.glyphspackage -o sources/build-prep/shantellsans-wght_ital_IRGL.glyphs
Reading: sources/shantellsans-wght_ital_IRGL.glyphspackage
Saving: sources/build-prep/shantellsans-wght_ital_IRGL.glyphs/shantellsans-wght_ital_IRGL.glyphs
Traceback (most recent call last):
  File "/Users/stephennixon/type-repos/shantell-sans/venv/bin/glyphspkg", line 8, in <module>
    sys.exit(main())
  File "/Users/stephennixon/type-repos/shantell-sans/venv/lib/python3.10/site-packages/glyphspkg/cmdline.py", line 48, in main
    package_to_single(input_path, arguments.output_path)
  File "/Users/stephennixon/type-repos/shantell-sans/venv/lib/python3.10/site-packages/glyphspkg/package_to_single.py", line 51, in package_to_single
    save_to_plist_path(glyphs_file, output_file_path)
  File "/Users/stephennixon/type-repos/shantell-sans/venv/lib/python3.10/site-packages/glyphspkg/plist.py", line 15, in save_to_plist_path
    with codecs.open(plist_path, "wb", "utf-8") as f:
  File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/codecs.py", line 905, in open
    file = builtins.open(filename, mode, buffering)
FileNotFoundError: [Errno 2] No such file or directory: 'sources/build-prep/shantellsans-wght_ital_IRGL.glyphs/shantellsans-wght_ital_IRGL.glyphs'

This happens whether I try to run glyphspkg from the command line or from a Makefile. I might be doing something wrong, but I don’t think I am...

Thanks again!

setup.cfg: license_file parameter deprecated and will be unsupported by 2023-10-30

The following warning will pop up during package build:

> /usr/lib/python3/dist-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
> !!
> 
>         ********************************************************************************
>         The license_file parameter is deprecated, use license_files instead.
> 
>         By 2023-Oct-30, you need to update your project and remove deprecated calls
>         or your builds will no longer be supported.
> 
>         See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
>         ********************************************************************************
>

jenskutilek / glyphspkg Goto Github PK

glyphspkg's People

Contributors

Stargazers

Watchers

Forkers

glyphspkg's Issues

"--output" arg seems to incorrectly nest output filepath

setup.cfg: license_file parameter deprecated and will be unsupported by 2023-10-30

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent