jeremyeng / cs4500_project Goto Github PK

Please change your tests so that our code compiles

We did our implementation based on your previous API with two separate string and object queues.
I would like to open a pull request to update the tests on the TestUpdates branch to address some of the problems with you old test suite:

1. Segfault when delete string3.
2. A bunch of redeclaration issues for popped on lines 84-96.

Would it be possible to add me as a contributor, so I can open a pull request to update that branch?
If not would it be possible to furnish those fixes? I believe they have already been fixed for the version on master.

for some reason the compiler throws this error when I try to compile code with a call to size(): "expression preceding parentheses of apparent call must have (pointer-to-) function type".

would you consider renaming it to get_size() or something?

You need to #include<assert.h> in the test-queue.cpp

#12 asks to change the tests. I know the other team isn't using the current Queue class, but our team is, and if you're going to merge the changes to the Queue class to create only 1 class, then the tests should be updated to reflect these changes. Otherwise revert the changes and we'll implement the original design.

There is nothing about the Piazza post mentioned in #12 that refers to Queue. The Array changes were suggested because the spec says they need to support primitive types as well. However, nothing about the spec suggests that primitive types need to be supported in Queue, or that Queues must be strongly typed, so that's why we suggested reducing code duplication by creating only 1 Queue class for Objects. We would rather not overcomplicate things and stick with the current design.

But again, regardless, tests should match the current API in the repo. So either the current API needs to be reverted or the tests need to be changed.

Thanks

These repositories contain the APIs you should implement

1. Queue

https://github.com/austenke/a1-part2.git

2. Map

https://github.com/kachmarma/cs4500-a1-p2.git

3. Array

https://github.com/egan-seamus/software-dev.git

Some of the tests in these functions compare Strings when they should be comparing Objects.