Giter VIP home page Giter VIP logo

Comments (5)

jerone avatar jerone commented on June 5, 2024 1

Lot's of issues where fixed in version 0.1.0, but still some left, based on my own findings:


					<tr
						*ngIf="
							currentMutation.address.opmerking !== null &&
							currentMutation.address.opmerking.length > 0
						">

Issue is the one-off error position.
Potential reason: multi-line *ngIf.


@Component({
	template: `
		<form clrStepper [formGroup]="form">
			<clr-stepper-panel formGroupName="group">
				<button clrStepButton="next" navigateToNextStep="true">Next</button>
			</clr-stepper-panel>
		</form>
	`
})
class TestComponent {
	@ViewChild(ClrStepButton, { static: false }) public button: ClrStepButton;

	public form = new FormGroup({ group: new FormGroup({}) });
}

Which resolves to incorrect HTML with this. before the double quote:

from eslint-plugin-angular-template-consistent-this.

jerone avatar jerone commented on June 5, 2024

Correct. I didn't complete the plugin yet. It's kind of blocking on angular-eslint/angular-eslint#384

from eslint-plugin-angular-template-consistent-this.

jerone avatar jerone commented on June 5, 2024

It looks like I found an solution in fb7c29c. Will release a new version soon.

from eslint-plugin-angular-template-consistent-this.

jerone avatar jerone commented on June 5, 2024

More use-cases have been patched in version 0.2.0.

Aldo, all tests are green, after running ng lint --fix in my project, not all cases are fixed correctly (specifically see comment above).

Fixing those edge-cases manually, they don't report.

Side-note: I also noticed differences in lint fixing when running ng lint --fix and saving file with settings.json:

	"editor.formatOnPaste": true,
	"editor.formatOnSave": true,
	"editor.formatOnType": true,
	"editor.codeActionsOnSave": {
		"source.fixAll.eslint": true // Fix all fixable ESLint rules.
	},

from eslint-plugin-angular-template-consistent-this.

jerone avatar jerone commented on June 5, 2024

I'll do some more tests, but for now, I'm marking this issue as fixed.

from eslint-plugin-angular-template-consistent-this.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.