jeryn99 / regeneration Goto Github PK

@SandedShoes can I do this one 😄

🙄

just how many times is this one going to come back...

the past 3 versions there is a 20-30 second freeze when opening the inventory first time after loading a world. Version 1.3.8. also crashes afterwards: https://pastebin.com/wuQdnjcS
I do not have lucraft installed and have disabled skinchanging if this matters.

OK, so when I regenerate, I get random potion effects, which is normal (I think). But then the next time I take damage, I start getting more potion effects. Also, along with the potion effects, I randomly just get stuck underground which I'm not sure what that is caused by.

Limbs don't reset

Whenever I use a Fob watch, dungeon loot or creative inventory got, it doesn't give me any regenerations whatsoever, whereas, in the Beta download, it does.

^

We never explicitly reset the life count, but it still gets reset. From my understanding this is because the capability data isn't cloned over properly when the player dies.

So how should we handle not-losing then? Save the last regen count and giving that back on respawn? Can we just copy the data over on death (I assume so) and how?

either make animation faster or sound slower

If you have a suggestion or want to make your voice heard, reply to this issue with this format below:

• Suggestion name:
• What does the suggestion entail:
• Does it change anything currently existing in the mod?:
• Why should we add your suggestion:

Please use proper punctuation (capitals, line breaks, a period after each sentence, commas ...) so that we don't have to decipher what you're trying to say.
If you would like to discuss a suggestion directly, contact Fril#0761 or HoldYourWaffle#2422 on discord.

Was about to die and the grace period/regenerate now prompt popped up. I opted for the grace period, the text glitched out a bit, and that was that. A little while later I tried regenerating and nothing happened, and I saw my cycle was at 0. I did still have the slowness from the grace period, though.

Version 1.3.4
After regeneration I get stuck in the pose, but the outer skin does not (if that makes sense?).
In the screenshot you can see a brown sleeve (from my outer skin) along both sides of the body. Those sleeves just function like arms now while the arms themselves are stuck in the cross pose.

i died in first person, got kicked into third person, entered grace period, had to press F5 to go back into first person

and when you press r to regenerate mid grace period you aren't put into third person

If you take damage whilst regenerating you lose the cycle and don't die.
When you do you lose the regeneration colour configuration.

The 1st time you are regenerating it will say you are regenerating for the 1nd time, the 2nd time it will say you are regenerating for the 2rd time, the 3rd time it will say you are regenerating for the 3th time

I'm not sure what's going on but since updating to the latest version of the Regeneration Mod on my server, the server crashes whenever I join.
https://pastebin.com/78Fd1vAV

(From #44)

• Mark "sessions" that have finished (death, leaving world, ...) [no longer applicable]
• Improve the layout of the debugger
• Correctly update
• Re-adding the dX & dY switches
• How does this behave on a dedicated or LAN server? (perfectly)
• Update GUI when extracting/gaining regens
• Add animation ticks
• Adding the actual switch for debug mode
• Cleanup & document (of course)

Encountered some bugs with the animation effect, can't fix them myself however as I suck at anything GL/rendering related.

• Some things are rendered on top the the effect including: water, smoke particles, slimes and some other mobs (not all though)
• The effect "turns solid" if fire spawns (probably with other light sources too)
• When wearing armor, once the player itself starts glowing the glow goes through the leggings
• If possible we shouldn't render the items in the hands of the player while it's regenerating. This is isn't exactly a bug but it looks kind of silly
• There's a lot of lag when you get killed during your regeneration. Shift+F3 menu shows that it's the gameRenderer that causes it, could it be that some kind of renderer from us is still being run? (Seems unlikely though)
• The animation is reduced to a broken piece of nothingness when using shaders. It doesn't matter what shader, as long as you use shaders the animation breaks

Whenever I set Textured Regeneration to yes and click save then go back to settings, it has defaulted back to no. Has textured regeneration not be added yet or is this a bug?

when regenerating with mo'bends mod active the player turns invisible and there is no visual effects.

As partially discussed in #13:

If you disable traits and load your world all traits will be removed and you won't get any.
When you enable traits again and load such a world, the traits become "stuck" causing a crash upon every regeneration.

The TimelordSuperpowerHandler.getAbilities() list is empty when randomizing traits for some reason. Which is weird because the only thing disabling does since 675b03b is locking all traits (I reverted using the Lucraft disabling system as it doesn't really do anything), it shouldn't delete traits from any list. Yet the list is still empty for some reason.

I really can't find the issue here, and it's pretty game breaking too. There may be a syncing issue involved too, although I have slim evidence that suggests that.

Describe the bug
I had this mod along with others that may modify the player model, and when I opened my Creative Inventory's Survival mode (with the armor slots) I crashed.

To Reproduce
Steps to reproduce the behavior:

1. Load this mod with others that modify player model, like Galacticraft
2. Open inventory
3. Crash!

Expected behavior
The model would have appeared fine and no crash.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
crash-2019-02-02_12.17.29-client.txt

Maybe they used a different base class for their mobs?

https://pastebin.com/AvtzTEZX

^

First of all I want to say that I absolutely love this mod (you could say its absolutely fantastic) and that I'd love to contribute to it. I actually have a lot of fixes/ideas/improvements that I'm going to PR (It's quite possible you'll get sick of it 😅)

My question is if the future of this mod is with or without the LucraftCore? Quite important to know where I should base my changes on.

Also I found quite a few bugs/easy enhancements while doing some basic tests, should I create a seperate issue for all of them? I'm probably gonna fix/do them all myself so I could also just make 2 big PR's (one for the bugfixes and other containing the enhancements)

https://gist.github.com/lag42/75acabe6ca26c6ff3b57525195b35250

the text that says how many regenerations you have left when you regenerate says -1 after you've used your last one

i'm not completely sure if this is related to the trait that decreases your health or not

• Colors set are not reflected in the actual animation
• Colors set aren't even saved in the config (#24)
• Some comment somewhere is wrong
• I'm pretty sure the 'postRegenerationLevel' is unused now although I haven't tested it
• Maybe we should add an option for the level of the effect of your trait?

As far as I can see the following branches are useless and could be deleted:

• gui
• master-traits
• master-1.12.2
• standalone

We should add back a readme with instructions for grace and stuff

BUGS

• Skin overlay while burning is 1 pixel short on arms when changing between alex/steve models
• Keybindings integrate horribly with lccore
• Can't throw away fob watch
• Skin changes are only seen by those that see the regen
• The limb rotation animation doesn't play when using a keypress
• GUI tab behaves weird with LCCore tabs (tab buttons are detected wrongly and undo button lights up for some reason)
• /give watch gives 2
• Some GUI related configs should be synced

IMPROVEMENTS

• Better skin GUI
• Explosions are still too loud
• More violent regeneration the longer you hold it in

TODO

• New skin system (#63)
• Reimplement toasts?
• dontLoseOnDeath config
• Fix the toast/core/overlay notification
• Heartbeat sound effect during grace
• Better skin GUI
• Issue #59, #48 and #40
• Add hand-glow timer to debugger

For some reason, when I spawn in the game with this mod activated, my player skin seems corrupted or simply inverse somehow. Also, there's no Fog Watches in creative, all I could find were Time Lord Injections. This might be because I have The Dalek Mod installed, which give a functional but less interesting form of regenerations, but I'm unsure. Could anyone help at all?

Reported by CrazyOtters on the ThreeTag discord.

Can't test right now, but the regex we use to test for chests we want to add our loot table too is probably wrong.

https://paste.dimdev.org/tedadopoxo.mccrash

Title says it all. Feel free to ignore some things.

Final touches

• Custom toasts that don't cut off the text
• Update readme & curse screenshots
• Hand glow punch mechanic
• Documentation
• Improved fiery animation

Esthetic stuff

• Fob watch is kind of hard to see in your inventory

UI stuff

• There's no way to return to your inventory from the regeneration menu*
• Pressing reset in the color config screen closes the UI*

Bugs

• (Not sure about this one) While testing I'm a new player everytime I run the game. However, my regeneration counter is carried over. Won't this cause issues/conflicts? Is this just singleplayer game behavior? What does this do on a lan world? So many questions again....
• The regeneration 'music' is too short for the actual animation, starting over before the animation is complete. Normally this is masked by the noise of the explosions
• Killing yourself while choosing or regenerating doesn't do shit (fixed, but:)
• Death mid-regen isn't handled properly*
• Your custom color is not applied to your body (only the arms change color)
• You can regenerate multiple times at once by pressing 'R'
• Pressing 'R' during grace period will start the regeneration, but will not change your perspective
• Just letting the regeneration happen during grace period won't change your perspective
• Shift clicking an arch with 0 regens left will act as if you didn't shift click*

Config stuff

• The 'start as a timelord' option is misleading, we should either change the option to say that you start with a watch or change the behavior so that you actually start as a timelord
• Add a 'start with x regens' option (2 modes: getting that many in a new world, or getting that many each time you die)*
• Add a mode for infinite regenerations*
• disableArch instead of disableWatch*
• The dontLoseUponDeath entry is confusing*
• The LangKey annotation value are not in the lang file, is this intented? Should we add them? Are the annotions useless? So many questions....
• Useless 'regen' category*

Other stuff

• Immediate regeneration plays a sound that "builds up", although the animation is immediately on full force
• Mixed camel/snake case in language file*
• Heartbeat sound language entry missing*
• Some language entries still use the 'Chameleon Arch' name*
• Some language entries are duplicate, and the whole file in general is just a mess*
• Version is listed as ${version} in the in-game mod list*
• Add github release*
• update.json lists the Weepeing Angels homepage*
• Missing updateUrl in mcmod.info? (I have no idea how that system works)

My humble opinion (especially for these points: feel free to ignore it)

• You should be vulnerable while regenerating in my opinion. There are already explosions while you're doing it, making it virutally impossible to die. I think we should put off regenerating your health & giving the absorption effect (especially that last one) until you finish your regeneration
• In addition to the previous point, the regeneration potion effect level is too high while 'choosing' making it again really hard to die. Lowering this level would add more of a rush to choose.
• Not sure how this is handled right now, but I think you should either die for real if you get killed while choosing, or being forced to regenerate.
• Should you change perspective when choosing between grace/immediate regen? I feel like it creates a lot of chaos when you're in a fight for example, and it severely limits you're ability to make the right choice.
• Hydro said you can't move when choosing, and I agree that that's pretty bad (in combination with my previous point). I think we should limit your speed like in the grace period.

Readme stuff

• Change the curseforge readme
• I should add the pressing of R to the readme concept*
• The default range for knockback is 7 instead of 5*
• Add the fact that you can craft an empty watch

Ideas from hydro

• Random damage in last minutes of grace period*
• Knockback enemies when first killed
• Nausea in last minutes of grace period*

Random ideas from me

• Toast based notification system
• Particle effect when opening arch (like grace period)
• Command for setting the remaining regenerations
• Add a check in build.gradle to make sure we update update.json*

Sometimes you can get stuck between being dead and alive when killed during grace.
No idea what causes this, nor have I been able to reliably reproduce this.

I am getting a crash ~ 30 seconds into a new world after adding galacticraft to my pack. Not sure if I should post here or with them?
Here's my log: https://pastebin.com/iyBJkNHJ

When you die after running out of regenerations, you keep your last incarnations abilities, is there a way to wipe that?

After spending two days patching this back together over the course of two days, I need some help with the following if it's unchecked as my time is becomign conusmed again slowly (I will still be working away at this)

If you have access to the project, just go ahead and do them, else make a PR and I'll look it over

• Add GUI for customization back (NOTE: Done, but needs to be made to look a lot prettier than it currently is)
• Customization stlye stuff within the capability, as right now it just defaults to the default style with no option to change
• Better visuals when you are within your grace period, maybe a beating heart in the top right with a remaining time until you hit death?
• More regeneration types!!!
• Slower walk speed in the grace period, I can maybe do this with reflection or the attributes thing

I know that some have difficulty understand the way I handle things in code, like, wtf are solace ticks and why do they keep going up
If you want to help and have no idea wtf I'm doing, feel free to contact me on discord (Sub#0761) and I'll help you out

• The 'hover' for the tab seems a bit dark to me but that could just be me
• Cancel doesn't go back to your inventory
• Reset doesn't work
• Saving does weird stuff (#24)
• The color set doesn't always persist, although sometimes it suddenly does

Sorry this is just a note/reminder to myself.

Reported by someone in my curse pm's:

Haven't tested it myself, but I can imagine that there's some incompatibility in the render code somewhere.

if you become a time lord using a full chameleon arch it will still have it's full 12 regenerations in it after you use it, since you're no longer considered a time lord after you run out of regenerations this means you get infinite regenerations as long as you have the arch

The customiser button in the traits section is not accessible...

P.S is there a feature (if not can u add) where you regen and don't get traits?