jesperbjerke / laravel-api-query-builder Goto Github PK

Is there a way to use eager loading with this library?

For example, when selecting a single entity via API, it would be cool to eager load relationships instead or generating a duplicate query:

// controller
public function show(Thing $thing): JsonResponse
{
    $thing->loadMissing('relation');

    return ThingResource::make($thing)->response();
}

As it is now, I need to do this:

public function show(Thing $thing, Request $request): JsonResponse
{
    $thing = (new QueryBuilder($thing, $request))->build()->first();

    return ThingResource::make($thing)->response();
}

Seems a bit un-pretty 🤔

Update:
My example above for showing a single entity didn't work, it always returned the first result of the new query.
This change did get me what I want, but it still uses the same code above in the controller.

// in QueryBuilder::build()
$query = $this->model->exists
    ? $this->model->newQueryForRestoration($this->model)
    : $this->model->newQuery();

Update 2:
Something like this could work pretty well I think, adding an extra method to the trait (same for loadCount).

// in QueryBuilderModelTrait
public function loadApiRelations(): self
{
    $with = collect(request('with'))
        ->map(fn($item) => explode(',', $item))
        ->flatten();

    return $this->loadMissing($this->validatedApiRelations($with));
}

Then it can be used as:

// controller
public function show(Thing $thing): JsonResponse
{
    $thing->loadApiRelations();

    return ThingResource::make($thing)->response();
}

I've been trying to filter results by counts (where[things_count]=5), but am getting Unknown column 'things_count', because of the way the query is put together:

select `things`.*, (select count(*) from `things`) as `things_count` from `things` where ((`things_count` = 5))

Playing around a bit, it should be having instead of where. I've tried adding the having to the list of allowed query methods, but that didn't work for me.

Adding a dedicated getHaving (as with groupBy and others) it does work though (having[things_count]=5), as it gives me:

select `things`.*, (select count(*) from `things`) as `things_count` from `things` having `things_count` = 5

I'm just wondering if I'm missing something here and there is actually a way to filter by *_count fields.