Comments (12)
Hi, I've been investigating this and it's related to the fact that we build with browserify (see issue here). I'm going to switch the builds of this, qj and card to webpack to resolve, hopefully in the next week.
from payment.
Sorry, just realised this is a duplicate of #1. However the fix specified there (loading payment/src/payment
instead of just payment
) doesn't work - you end up with the same error from a dependency of payment itself:
WARNING in ./~/card-react/~/payment/~/qj/lib/qj.js
Critical dependencies:
1:449-456 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
@ ./~/card-react/~/payment/~/qj/lib/qj.js 1:449-456
You would also need to load qj
by its src path to avoid this. PR incoming..
from payment.
This should be fixed under 0.0.10!
from payment.
works great! they are ready to merge over at shatran/card-react#3 once npm updates (:
from payment.
whoops! thought I published it - v0.0.10 is now published with the fix!
from payment.
Is this indeed fixed? I'm seeing the same warning on 0.0.12 (and webpack 1.12.9)
PS. Thanks for the great work @jessepollak !
from payment.
I am seeing the same issue in webpack
from payment.
Seeing the same issue here aswell.
from payment.
@Scottjutsu @FutureKode did you find another library to work with instead of this one?
@jessepollak would it be possible to re-open this issues again?
from payment.
Reopened — I can take a look at this over the weekend!
from payment.
@jessepollak thanks dude 👍
from payment.
Hi — can y'all try building with 2.0.0-beta1
? I believe all these issues are now resolved :)
from payment.
Related Issues (20)
- Diners club cards format as Visa HOT 3
- Troy Credit Card Support HOT 5
- Maximum call stach execution HOT 1
- Overrides global Payment HOT 1
- ReferenceError: global is not defined HOT 6
- JCB regex wrong HOT 3
- The length of the visa card is 13, 16, please update HOT 5
- format credit card number after Autofill HOT 12
- Payment don't work with jest HOT 5
- Provide function to remove listeners from a input HOT 1
- iOS class="cc-number" HOT 18
- Trying to get in touch regarding a security issue HOT 6
- Strange CC editing behavior
- Old elo's pattern HOT 3
- "jasmine index.spec.js" result => Reference Error: document is not defined HOT 1
- Payment.fns.restrictNumeric is not a function- should it be Payment.restrictNumeric?
- Payment.J is undefined HOT 3
- DOM-free version?
- Discover and JCB can also be 19 characters long HOT 2
- On Copy Paste card is not autoformatting. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from payment.