Giter VIP home page Giter VIP logo

Comments (12)

jessepollak avatar jessepollak commented on August 23, 2024 2

Hi, I've been investigating this and it's related to the fact that we build with browserify (see issue here). I'm going to switch the builds of this, qj and card to webpack to resolve, hopefully in the next week.

from payment.

pospi avatar pospi commented on August 23, 2024

Sorry, just realised this is a duplicate of #1. However the fix specified there (loading payment/src/payment instead of just payment) doesn't work - you end up with the same error from a dependency of payment itself:

WARNING in ./~/card-react/~/payment/~/qj/lib/qj.js
Critical dependencies:
1:449-456 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
 @ ./~/card-react/~/payment/~/qj/lib/qj.js 1:449-456

You would also need to load qj by its src path to avoid this. PR incoming..

from payment.

jessepollak avatar jessepollak commented on August 23, 2024

This should be fixed under 0.0.10!

from payment.

pospi avatar pospi commented on August 23, 2024

works great! they are ready to merge over at shatran/card-react#3 once npm updates (:

from payment.

jessepollak avatar jessepollak commented on August 23, 2024

whoops! thought I published it - v0.0.10 is now published with the fix!

from payment.

Scottjutsu avatar Scottjutsu commented on August 23, 2024

Is this indeed fixed? I'm seeing the same warning on 0.0.12 (and webpack 1.12.9)

PS. Thanks for the great work @jessepollak !

from payment.

FutureKode avatar FutureKode commented on August 23, 2024

I am seeing the same issue in webpack

from payment.

chrisfinch avatar chrisfinch commented on August 23, 2024

Seeing the same issue here aswell.

from payment.

chrisfinch avatar chrisfinch commented on August 23, 2024

@Scottjutsu @FutureKode did you find another library to work with instead of this one?

@jessepollak would it be possible to re-open this issues again?

from payment.

jessepollak avatar jessepollak commented on August 23, 2024

Reopened — I can take a look at this over the weekend!

from payment.

chrisfinch avatar chrisfinch commented on August 23, 2024

@jessepollak thanks dude 👍

from payment.

jessepollak avatar jessepollak commented on August 23, 2024

Hi — can y'all try building with 2.0.0-beta1? I believe all these issues are now resolved :)

from payment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.