@pytest.mark.parametrize(
    ("number", "expected"),
    [
        (1, 0),
        *((i, 1) for i in range(2, 10)),
        *((i, 2) for i in range(10, 26)),
        *((i, 3) for i in range(26, 50)),
        (50, 4),
    ],
)
def test_circle_number(number, expected):
    assert get_circle_number(number) == expected

Plugin reports

Consider removing conditions from tests to ensure that all statements are executed

One can use ... instead of pass as a placeholder for an empty test, e.g.

class TestSolve(unittest.TestCase):
    def test_returns_correct_result(self):
        ...

The plugin doesn't report that.

Hi,

Is there anywhere I can find an example command on how to run the tools in CLI because I saw that in the papers but I don't see it anywhere in the repo.

java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
at java.base/java.util.Arrays$ArrayList.get(Arrays.java:4351)
at org.jetbrains.research.pynose.plugin.inspections.unittest.RedundantAssertionTestSmellUnittestInspection$buildUnittestVisitor$1.visitPyCallExpression(RedundantAssertionTestSmellUnittestInspection.kt:29)
at com.jetbrains.python.psi.impl.PyCallExpressionImpl.acceptPyVisitor(PyCallExpressionImpl.java:29)
at com.jetbrains.python.psi.impl.PyBaseElementImpl.accept(PyBaseElementImpl.java:69)
at com.intellij.codeInspection.InspectionEngine.acceptElements(InspectionEngine.java:65)
at com.intellij.codeInspection.InspectionEngine.createVisitorAndAcceptElements(InspectionEngine.java:56)
at com.intellij.codeInsight.daemon.impl.LocalInspectionsPass.runToolOnElements(LocalInspectionsPass.java:320)
at com.intellij.codeInsight.daemon.impl.LocalInspectionsPass.lambda$visitPriorityElementsAndInit$4(LocalInspectionsPass.java:279)
at com.intellij.util.AstLoadingFilter.forceAllowTreeLoading(AstLoadingFilter.java:161)
at com.intellij.util.AstLoadingFilter.forceAllowTreeLoading(AstLoadingFilter.java:153)
at com.intellij.codeInsight.daemon.impl.LocalInspectionsPass.lambda$visitPriorityElementsAndInit$5(LocalInspectionsPass.java:277)
at com.intellij.util.AstLoadingFilter.disallowTreeLoading(AstLoadingFilter.java:132)
at com.intellij.util.AstLoadingFilter.disallowTreeLoading(AstLoadingFilter.java:121)
at com.intellij.codeInsight.daemon.impl.LocalInspectionsPass.lambda$visitPriorityElementsAndInit$6(LocalInspectionsPass.java:277)
at com.intellij.concurrency.ApplierCompleter.execAndForkSubTasks(ApplierCompleter.java:136)
at com.intellij.concurrency.ApplierCompleter.execAndForkSubTasks(ApplierCompleter.java:149)
at com.intellij.openapi.application.impl.ApplicationImpl.tryRunReadAction(ApplicationImpl.java:1096)
at com.intellij.concurrency.ApplierCompleter.lambda$wrapInReadActionAndIndicator$1(ApplierCompleter.java:92)
at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:688)
at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:634)
at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:64)
at com.intellij.concurrency.ApplierCompleter.wrapInReadActionAndIndicator(ApplierCompleter.java:104)
at com.intellij.concurrency.ApplierCompleter.lambda$compute$0(ApplierCompleter.java:83)
at com.intellij.openapi.application.impl.ReadMostlyRWLock.executeByImpatientReader(ReadMostlyRWLock.java:167)
at com.intellij.openapi.application.impl.ApplicationImpl.executeByImpatientReader(ApplicationImpl.java:178)
at com.intellij.concurrency.ApplierCompleter.compute(ApplierCompleter.java:83)
at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:746)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)

Thank you for the great job! Could you file a license agreement to the project, please?

!!!Actions required!!!
We have published current plugin-utilities lib version from master branch to space maven repository and in a week planning to modify api (so master branch will become invalid). Please, replace plugin-utilities lib git-based installation in your build.gradle.kts with (standard dependency declaration) by adding space repository and declaring required dependencies:

repositories {
    maven(“https://packages.jetbrains.team/maven/p/big-code/bigcode”)
}

dependencies {
    implementation(“org.jetbrains.research:plugin-utilities-core:1.0")
    implementation(“org.jetbrains.research:plugin-utilities-test:1.0")
    implementation(“org.jetbrains.research:plugin-utilities-python:1.0")
}

"Test maverick" inspection highlights the class name instead of the method. With a big enough class containing a lot of test cases it is a bit annoying to search for the offending method. I would prefer to see the exact test method(s) highlighted instead.

There is a well-known Python test runner called nose (not super trendy today though). The name collision is quite unfortunate.

• Both the plugin and the package have a similar application field (unit testing)
• PyNose plugin doesn't actually support nose, which is somewhat counterintuitive based on its name

Project: pip
File link: https://github.com/pypa/pip/blob/12dad051804907fae1b2232fba3d218035881a60/tests/unit/test_req.py#L494

@OlesiaSub
Do we need to check that there was a reassignment of the variable between duplicate assertions to avoid such FPs?

I followed the whole readme guide, but in the last step, when I ran the runner.py script, I got the following error:

Will there be support for newer builds?

PyNose skips identifying numeric literal within the assertion statement as magic numbers.

Here is the settings in Editor > Inspections

Tool used: pyNose 1.0.0
IDE: PyCharm Community 2022.2.3
Python: 3.10

Hello.

Do you have any plans to use this plugin as separate entity, for example flake8-pynose or self-sufficient python package? For include this features in CI pipeline or precommit hook?

Thanks.

In cases like this duplicate assertion is detected and removed incorrectly.

with self.assertRaises(ValueError):
    x = 3
with self.assertRaises(ValueError):
    x = 4

leads to this:

with:
    x = 4

Hi there,

currently in my PhD research I am facing data clumps to be refactored. Maybe you will consider this code smell too, as it is also a design smell.

I am currently developing a IntelliJ IDEA plugin.
I am facing the problem to load all dependencies and getting the qualified name of a class.