jf002 / cfrfm69 Goto Github PK
View Code? Open in Web Editor NEWRFM69 driver library for ESP32/Arduino
License: MIT License
RFM69 driver library for ESP32/Arduino
License: MIT License
Hi,
I love the simplicity of your library and the effort you have put in to coding up the registers and values but I found one or two issues when using it for Receiving Packets and analysing a 433MHz Transmitter I had.
I would like to suggest some edits for bugs that I have found and fixed.
Issues found in Version 0.1.2 as exposed in platformIO library: https://platformio.org/lib/show/6161/cfRFM69
SetListenMode()
was using the wrong register (Registers::PacketConfig
instead of Registers::ListenSettings
)ReadMaskWriteRegister
was not applying the mask correctly to preserve the existing bits in the register.ReadMaskWriteRegister
instead.
SetOperatingMode()
AbortListen()
EnableListen()
EnableSequencer()
I can either issue a pull request or post you a diff.
Many thanks for the excellent work in this library.
TJ
Hi,
there are a few things to fix in your source files (in RFM69.cpp):
please delete line 311 it is forbidden to set register 0x11 like that:
WriteRegister(static_cast<uint8_t>(0x11), static_cast<uint8_t>(0xff));
in line 364 Registers::ListenRxDuration
is the wrong register, please set it to 0x11
in line 365 there is one | at the end too many, please remove it:
static_cast<uint8_t>((outputPower & 0x1F) | (pa2 ? (1 << 5) : 0) | (pa1 ? (1 << 6) : 0) || (pa0 ? (1 << 7) : 0)));
now it should work, thanks for your code
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.