jf002 / cfrfm69 Goto Github PK

Hi,

I love the simplicity of your library and the effort you have put in to coding up the registers and values but I found one or two issues when using it for Receiving Packets and analysing a 433MHz Transmitter I had.

I would like to suggest some edits for bugs that I have found and fixed.

Issues found in Version 0.1.2 as exposed in platformIO library: https://platformio.org/lib/show/6161/cfRFM69

1. SetListenMode() was using the wrong register (Registers::PacketConfig instead of Registers::ListenSettings)
2. I have implemented a `ReadFIFO() function that allows one to take advantage the more efficient multi-byte read of the FIFO rather than calling multiple ReadRegister(0x00)
3. ReadMaskWriteRegister was not applying the mask correctly to preserve the existing bits in the register.
4. I found that in certain config setters the bit twiddling was not correct and I have recoded the following methods to use the now fixed ReadMaskWriteRegister instead.

   SetOperatingMode()
   AbortListen()
   EnableListen()
   EnableSequencer()
   

I can either issue a pull request or post you a diff.

Many thanks for the excellent work in this library.

TJ

Hi,

there are a few things to fix in your source files (in RFM69.cpp):

1. please delete line 311 it is forbidden to set register 0x11 like that:
   WriteRegister(static_cast<uint8_t>(0x11), static_cast<uint8_t>(0xff));

2. in line 364 Registers::ListenRxDuration is the wrong register, please set it to 0x11

3. in line 365 there is one | at the end too many, please remove it:
   static_cast<uint8_t>((outputPower & 0x1F) | (pa2 ? (1 << 5) : 0) | (pa1 ? (1 << 6) : 0) || (pa0 ? (1 << 7) : 0)));

now it should work, thanks for your code