jgarber623 / indieweb-endpoints.cc Goto Github PK

Consider accepting HTTP POST requests to /search when request is for application/json:

curl -H 'Accept: application/json' -d 'url=https://sixtwothree.org' https://indieweb-endpoints.cc/search

When params[:url] is a loopback (e.g. localhost) or a private (e.g. 10.0.0.0/24) URL, halt with a 400 error.

To-Do

• remove github: source from gem 'roda' in Gemfile
• rerun bundle install
• remove git from list of packages installed in Dockerfile during "Production Build Stage"

See e.g.: https://indieweb-endpoints.cc/search?url=https%3A%2F%2Fdoubleloop.net

micropub_media is missing, and micropub is reported as the media endpoint.

The actual values are:

<link rel="micropub_media" href="https://doubleloop.net/wp-json/micropub/1.0/media" />
<link rel="micropub" href="https://doubleloop.net/wp-json/micropub/1.0/endpoint" />

https://indieweb-endpoints.cc/search?url=http%3A%2Faaronpk.com

Suggestion: add the logic for following and resolving redirects according to IndieAuth and also include that url in the response

https://indieauth.spec.indieweb.org/#url-canonicalization

Specifically, thinking about returning 405 and 406 errors where it makes sense…

Simplecov is reporting the following missed lines:

+----------+-------------------------------+-------+--------+-------------------+
| coverage | file                          | lines | missed | missing           |
+----------+-------------------------------+-------+--------+-------------------+
|  87.23%  | lib/indieweb_endpoints/app.rb | 47    | 6      | 19-21, 56, 72, 74 |
+----------+-------------------------------+-------+--------+-------------------+