jhardy / figma-styled-components Goto Github PK

Seems like React is trying to infer the on prop as a default HTML prop. Getting the following warning when rendering an IconButton or an OptionButton:

Warning: Received `false` for a non-boolean attribute `on`.

If you want to write it to the DOM, pass a string instead: on="false" or on={value.toString()}.

If you used to conditionally omit it with on={condition && value}, pass on={condition ? value : undefined} instead.
    in div (created by styled.div)
    in styled.div
    in button (created by styled.button)
    in styled.button
    in OptionButtonFactory (created by Styled(Styled(Styled(OptionButtonFactory))))
    in Styled(Styled(Styled(OptionButtonFactory))) (created by App)
    in section (created by styled.section)
    in styled.section (created by App)
    in App (created by App)
    in App

maybe could be fixed by renaming the on prop to isOn?

Seems like forget to export Tabs component in src/index.ts, could be fixed by adding export * from './Tabs'

See screenshot:

There seem to be some shenanigans with height. Height of input is 12px, but line-height is 14px, so text is taller than input. Chrome and Firefox don't seem to mind that and render text outside of input, but Safari seems to be more strict.

The Netlify app can be renamed in the settings in order to have a better url like https://figma-styled-components.netlify.com which is free at the moment.