jianyuan / pocketbase-sveltekit-auth Goto Github PK

Hey, thanks for putting together this repo and the YouTube video.

I'm able to successfully register a user but for some reason $currentUser is null and when I look at local storage the pocketbase_auth is {token: '', model: null}

When I console log pb.authStore.model in hooks.client.js, it's null

pb.authStore.onChange(() => {
  console.log('pb.authStore CHANGE', pb.authStore.model);
  currentUser.set(pb.authStore.model)
  document.cookie = pb.authStore.exportToCookie({ httpOnly: false })
})

Any ideas?

The logged in user's session does not get sent from the server render, causing a "flash of logged-out content".

When the client scripts kick in, the user is correctly shown as being logged in.

Here's a video showing what I mean: https://gfycat.com/tintedunrulygemsbok

This template was shared with me in pocketbase/pocketbase#2949, but I noticed that it loads a single global PocketBase instance for each request in hooks.server.ts.

As mentioned in the above discussion, unless I'm misunderstanding the structure of the application, event.locals.pb = pb doesn't create a new instance. It uses the same object instantiated in $lib/pocketbase.ts.

You need to create a new PocketBase instance for each server-side request because requests from different users could write over the same pb.authStore object.

For hooks.client.ts is OK to have a single global PocketBase instance because the pb.authStore in this case is kept in the user's browser and it is not shared with the other users.

My recommendation would be to create and export a function from $lib/pocketbase.ts that will create a new PocketBase instance every time when it is called in hooks.server.ts.

Under which license is this repository available? Please add a license file to let the users know.

https://docs.github.com/es/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository

https://docs.github.com/es/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository

I think it would be great to have loading indicators in the forms will the request is processed and also have the form fields disabled in the meantime.

Also, when there is an error, it would be great when the server actions would return the error details for frontend notices.

I totally understand, when you don't want to have all of this implemented here, to keep things simple and related to pocketbase only.

However, when you also think this would be nice to have (should not be that much boilerplate), then I could open a PR for those features.

What do you think? @jianyuan

Any tips on how to achieve this?

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Other Branches

These updates are pending. To force PRs open, click the checkbox below.

• chore(deps): update dependency vite to v4.5.2 [security]
• chore(deps): update dependency @sveltejs/adapter-auto to v2.1.1
• chore(deps): update dependency @tailwindcss/forms to v0.5.7
• chore(deps): update dependency autoprefixer to v10.4.17
• chore(deps): update dependency postcss to v8.4.34
• chore(deps): update dependency postcss-load-config to v4.0.2
• chore(deps): update dependency svelte to v4.2.10
• chore(deps): update dependency @sveltejs/kit to v1.30.3
• chore(deps): update dependency eslint to v8.56.0
• chore(deps): update dependency eslint-config-prettier to v9.1.0
• chore(deps): update dependency prettier to v3.2.5
• chore(deps): update dependency prettier-plugin-svelte to v3.1.2
• chore(deps): update dependency svelte-check to v3.6.3
• chore(deps): update dependency svelte-preprocess to v5.1.3
• chore(deps): update dependency tailwindcss to v3.4.1
• chore(deps): update dependency typescript to v5.3.3
• chore(deps): update typescript-eslint monorepo to v6.21.0 (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency daisyui to v3.9.4
• fix(deps): update dependency pocketbase to ^0.21.0
• chore(deps): update dependency @sveltejs/adapter-auto to v3
• chore(deps): update dependency @sveltejs/kit to v2
• chore(deps): update dependency daisyui to v4
• chore(deps): update dependency postcss-load-config to v5
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository