jidarwish / javascript2 Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 35 KB

HTML 0.75% JavaScript 97.66% CSS 1.59%

javascript2's People

Contributors

javascript2's Issues

Well done brother

JavaScript2/week2/step3/index.js

Line 1 in 9fd491b

//creating a button and writing sth into it and assigning it to a value

👌

better way

JavaScript2/week3/script.js

Line 32 in 5b0e127

callback(data);

here you are parsing the request data and then you callback the render function, so you should pass an object not (theData), try to make it this way:
callback(xmlHttp.responseText);
and inside your callback parse the data into js object and then render your dom.

guide the user

JavaScript2/week3/script.js

Line 28 in 5b0e127

//do sth

here I advice you to add alert, to tell the user what is wrong and what he should input, try this:
if (xmlHttp.readyState == 4 && xmlHttp.status == 404)
alert('tell the user what should he do');

Nice code, smart solutions

You just did it, clear code, nice style, I see from your code that you understand everything and you will be a great developer.
keep going

Nice

Dear Ji , this is awesome , keep coding .

Very nice work, just two points

Hello Ji
Very nice work
Simple and clear code with comments to explain everything.
I just have two small points:

First <"div"> you created you can remove it if you don’t need it
Could you explain to me that which element you mean by “*” in the first tag in your CSS page. I don’t understand it

Recommend Projects