Bugs with 2.0.1 about enchantableblocks HOT 6 CLOSED

Super, so some registered furnace recipes don't have an input? Stack trace points here, which means I can't even check it, I actually have to catch the exception. I shouldn't be surprised by a lack of sanity in Minecraft, but somehow I never see it coming.

If you'd be willing to run a build with some debug messages that'd be helpful.

from enchantableblocks.

If you would please, try EnchantableBlocks 2.0.2-SNAPSHOT.
The debug will probably be quite spammy, but I'm interested in finding out if this is a default Minecraft recipe that's screwed up or if a plugin isn't playing nice.

from enchantableblocks.

Spam in console :

20.01 13:16:28 [Server] INFO Recipe with null InputChoice: minecraft:coralstay_fire_coral_wall_fan outputting ItemStack{AIR x 0}
20.01 13:16:28 [Server] INFO Recipe with null InputChoice: minecraft:coralstay_tube_coral_wall_fan outputting ItemStack{AIR x 0}
20.01 13:16:28 [Server] INFO Recipe with null InputChoice: minecraft:coralstay_bubble_coral_wall_fan

Huuum, CoralStay... I use this plugin in my server : https://www.spigotmc.org/resources/coralstay.60731/

The enchantments normally works.
But I don't always get the XP, for example with iron it's ok but not with stone (I didn't test others).

from enchantableblocks.

I don't mess with experience currently, that's just due to the fact that a single smelt of iron yields .7 to .1 from stone. Fortune doesn't affect the experience gain in 1.13 due to changes in how experience is handled, though I suppose I could revert that behavior to match 1.12 and lower. That said, furnaces storing exp would make fortune even more incredibly broken. Not sure how I feel about it in terms of balance, what do you think?

Yeah, CoralStay appears to be the issue. I guess I'll leave the exception catching, but the author should really consider revisiting their recipe creation.
There are currently no checks made to ensure the materials exist, and the NamespacedKey being created should be using the namespace coralstay, instead of minecraft and prefixing every recipe with coralstay_.

This is more of a Spigot issue, the server shouldn't be accepting problematic recipes. From what I can tell, the invalid input is "fine" when added to the crafting manager. Then, when the actual choice list is rebuilt converting back from NMS to Bukkit, the invalid input is not added, yielding an empty input list, which results in a null RecipeChoice.

from enchantableblocks.

Okay, I've also opened SPIGOT-4587 for the CB end.
For now, here's a build without the debug message: EnchantableBlocks.zip

I'm not going to do a full release because I believe this should be addressed by CB and individual plugins adding odd recipes.

from enchantableblocks.

With this version everything is ok so awesome :D

from enchantableblocks.