Giter VIP home page Giter VIP logo

enchantableblocks's Introduction

Hi there!

I'm a programmer with a career in CNC manufacturing. My focus is on Java, but I can work my way through other languages with relative ease as the need arises. I've worked with Bash, various SQL/NoSQL databases (MySQL, SQLite, PostgreSQL, etc.), and dabbled in Python, C#, and more. I can write G-code manually when required, optimizing or redefining tool paths and programs. I've also done systems administration for several communities I helped manage over the years.

I don't play Minecraft much any more, but I'm still active in the Spigot plugin development scene. In addition to my own repositories I maintain OpenInv, frequently contribute to GriefPrevention, and collaborate on Treasury.

ReadMe Card

enchantableblocks's People

Contributors

dependabot[bot] avatar jikoo avatar sgdc3 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

enchantableblocks's Issues

Enchantments bugs with 2.0.0

Hi,

With 2.0.0 (and Paper 1.13.2) there is only the fortune enchantment which works.
Furthermore, sometimes cobblestone gives charcoal instead of stone.
Sometimes everything works normally about enchantments but it's rare.
And that on the furnaces of old versions or the version 2.0.0

Thank you in advance.

ClearLagg kills repeating tasks when performing gc/stops

I have the latest release of this plugin (when it was called EnchantedFurnace) and it seems ClearLagg makes it stop whenever it garbage collects or halts the server (ex. on low TPS trying to reduce lag).

Nothing worth mentioning on the server log, it just happens.

Also, doesn't this plugin need a 1.13 compatibility upgrade?

Enchanted Furnaces won't combine

Hi,
I've updated the plugin to the latest version, as well as ensuring that the perms were set-up correctly; however, whenever I try and combine 2 furnaces they don't work; it becomes a ghost item, and the old furnaces are returned (without any EXP lost either).
Any help will be appreciated, and thanks in advance!

EnchantedBlocks.issue.mp4

Enchantments no longer work (Paper)

Hi,

For a few days now, the enchantments on the old ovens as on the new ones no longer work at all for no particular reason. The only thing that could have interfered with the plugin is I think the latest updates from Paper.
The problem must therefore lie between versions 700-750 because I updated yesterday from the 735 to 750 but the problems started before.

I am using Paper 1.16.5 and the latest version of the plugin (2.0.7).

Capture

Bug with Silk Touch and Efficiency (1.17.1)

Hi,

With the last version of this plugin (3.0.0) and Paper 1.17.1 there are various problems :

  • Silk touch enchantment no longer works
  • Efficiency doesn't work all the time

My players have done more extensive tests, especially with Efficiency : If you interact with the items in the oven, the Efficiency enchantment will resume working normally for a certain period of time. Otherwise there is only the 1st item which functions normally, then the speed is no longer accelerated. Therefore if the oven is fed automatically by hoppers for example there is no problem.

Thank you in advance.

Options to enable / disable use of furnace / blasting furnace / smoker.

I found you're putting those three materials together in a set - so this is not possible to only allow furnace to be affected by EnchantableBlock while blasting furnace and smoker are not.

Can you separate them and possibly make it configurable via config?

  • do you have personal contact like discord to reach? I've got few things to discuss.

Furnace duplication

Hi,

With the last version from my previous issue #11 (comment) and Paper 1.16.3 when you break an enchanted furnace with or without items inside, a classic furnace duplicates and drops with the rest.

Silk Touch and cooking tools

Hi,

Finally everything is not ok with 2.0.4 : when cooking iron or gold tools with coal (or other) is used 1 coal for 1 item.

I use PaperSpigot 1.14.4.

Experience Not Increasing with fortune

Whilst using a furnace whit fortune you will still receive 1 xp from cactus even if you receive 7 cactus green dyes, not sure if it's intended but was figuring that if result increases so should xp.

Enchantment Table dont Work

When Users in Survival put a Furnace in the Enchant table its show enchants when he add Lapis
the enchant gone and he cant select a enchant

Creative Work

Permissions added

Silk Touch and 1.14.4

Hi,

I use PaperSpigot 1.14.4 and the last version of this plugin (2.0.3)

I know you know about this bug (Silk Touch does not work correctly) via your last journal in Curse, but do you think you can fix it one day ?

Efficiency speed-up only applies if there are no other items to smelt.

First I'd like to say thank you for keeping up with this project.

Currently I'm having an issue with the enchanted furnaces' efficiency not being used after one item gets smelted.

If there are any 'cooked' items, the speed-up will only apply for the first one cooked. Everything else is 'vanilla.'

The only plugin I can think of that would cause this is McMMO.

Add option to keep furnaces cached in memory

Some servers don't mind about the memory usage of keeping all the furnaces loaded at runtime, there should be an option to disable the entire expiring cache system. (Data will be loaded on world load/unload)

Anvil Enchanting in GeyserMC

I'm using the Geyser plugin and my Bedrock player can't use Anvil Enchanting, but the Java player works fine.

McMMO and fortune enchant

Had a report that fortune enchant doesn't work on the furance because mcmmo double smelt over rides it?

quote from a ticket via my support

im glad someone else brought this up actually bc i was doing something similar the other day and got slightly confused
i was smelting coal ore with an ulti furnace which also has the fortune enchant
and i got double the amount of ore i smelted but i was expecting more from the fortune since i usually get double from mcmmo anyway

Enchantment displayed in the enchanting table

Hi,

The name proposed by the enchanting table when you try to enchant an oven is not at all the one you will have next, the proof in picture.

I use the last version of this plugin (3.0.0) and Paper 1.17.1.

2021-08-04_21_57_14 png 113ac1bbb3f67323eabdbac4d4fae004

2021-08-04_21_57_26 png 4cfa8bd571bb27d30a9f5c145721a517

Thank you in advance.

Unit Testing

I just want the sweet sweet satisfaction of checking little boxes.

Coverage

  • EnchantableBlocksPlugin
  • block
    • EnchantableBlock
    • impl.furnace
      • EnchantableFurnaceConfig
      • EnchantableFurnace
      • EnchantableFurnaceRegistration
      • FurnaceListener
  • config
    • EnchantableBlockConfig
    • data
      • MultimapEnchantEnchantSetting
      • SetEnchantSetting
  • listener
    • AnvilEnchanter
    • TableEnchanter
    • WorldListener
  • registry
    • EnchantableBlockManager
    • EnchantableBlockRegistry
    • EnchantableRegistration
    • RegionInUseCheck
    • RegionLoadFunction
  • util
    • Cache
    • EmptyCookingRecipe
    • Region
    • RegionStorage
    • enchant
      • AnvilOperation
      • AnvilRepairMaterial
      • AnvilResult
      • AnvilUtil
      • Enchantability
      • EnchantData
      • EnchantDataReflection
      • EnchantingTableUtil
      • EnchantOperation
      • Rarity

Reorganize Config

  • Configuration should easily support more blocks
    • Block settings should be sub-nodes
    • Per-EnchantableBlock impl serializable settings?
  • Expose advanced details
    • Will this be too complex for the average user to understand?
    • Separate anvil/enchanting table details
    • More than 1 incompatiblity per enchant
  • Enchantments should be referenced by namespaced key, not name

May opt to not offer conversion for configs - changes are going to be major but most people use default or only slightly modified config.

Problem with anvil costs

Hi, I've problem that after rebuilding anvils system RepairCosts of merging in anvil enchanted furnaces with furnaces or furnaces with enchanted books increased significantly. Is there a way to change, how furnace is interpreted by anvil cost system?

Ex.
If i merge:

  1. diamond_pickaxe + book (from gamemode) eff III = diamond_pickaxe eff III
  2. diamond_pickaxe eff III + book eff III = diamond_pickaxe eff IV
  3. diamond_pickaxe eff IV + diamond_pickaxe eff IV (both made as above) = diamond_pickaxe eff V
    At the end RepairCost nbt of diamond_pickaxe eff V is 7

If I make same thing with furnace instead of diamond_pickaxe repair Cost is 19.

Can I change it to work ex. like diamond pickaxe?

2.0.2-SNAPSHOT doesn't work on 1.14

I've compiled 2.0.2-SNAPSHOT and i've shaded lang3, the plugin loads and all, but i can't use the enchanting table to enchant a furnace, and when combining a furnace with a book in the anvil, it doesn't do anything, even though the furnace has the enchantment. Items always take 10s to process. Spigot version: git-Spigot-1eece4f-8879c31.

Bugs with 2.0.1

Hi,

In the console when a enchanted furnace is activated : https://pastebin.com/a06uqxEa

The bug with charcoal (2.0.0) is resolved but the enchantments doesn't work.

My furnace has Efficiency V, Unbreaking III, Fortune III and Silk Touch.

I use PaperSpigot 1.13.2.

This plugin does not work in PaperSpigot 1.14.2

I tested this plugin in a clean PaperSpigot environment and I saw that enchanting furnaces in a table is impossible. Maybe the event is force canceled? I think so because the three enchantment proposals appear just for one tick.

Using PS #96 on 1.14.2

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.