jiminy-billy-bob / layers-panel Goto Github PK

@dialog.add_bridge_callback("addGroupStart") do |wdl, groupName|
            @model.start_operation("Add group layer", true)
            self.initializeLayerDictID
            # puts groupName
            # puts @layerDictID
            @model.set_attribute("jbb_layerspanel_groups", @layerDictID, groupName) #Store group's name with ID
        end#callback addGroup

This doesn't play well. self.initializeLayerDictID starts an operation, and even though it's transparent you cannot nest operations. When you start a new operation it will interrupt the existing one.

"Whenever I use the Grab Location feature of SU to Geo-locate my model, the Google Earth Terrain and Snapshot layers come into the model, BUT Layers Panel assigns BOTH layers the same name..."Google Earth Snapshot", and the functionality of Layers Panel is broken.
If I open the standard SU Layers, both the "Google Earth Terrain" and "Google Earth Snapshot" layers are there, and work as expected."

http://sketchucation.com/forums/viewtopic.php?p=508738#p508738

http://sketchucation.com/forums/viewtopic.php?p=536281#p536281

After folding up the window it's not possible to close it. I assume this is because the tool window is larger under Windows 8 and the fold up code doesn't account for this.

I also assume this will appear in any Windows version if the user customize their Windows theme to have non-default frame sizes.

I had to resize the window by grabbing it's window frame.

http://sketchucation.com/forums/viewtopic.php?f=323&t=53906&p=502075#p502072

This pattern is crashing OSX unfortunately so one must avoid repeating some other way.

The New Layer and New Group works fine, but the Delete buttons doesn't delete any layers - nor is any error messages output.

"Delete Layers and delete content(s)" display a dialog box, but nothing happens after answering it.

I noticed when I used the plugin to move a layer to or from a group the Edit menu would say "Undo Properties".

It'd be nicer if it said "Undo Layer Group" or something like that.

For some reason, the icon toolbar is way too small. Even thought I followed the doc description (16x16 and 24x24). Works fine on windows.

http://sketchucation.com/forums/viewtopic.php?f=323&t=53906&p=501913#p501913

You have an option to disable the IE warning. Are there reports of issues with that warning when you have <meta http-equiv="X-UA-Compatible" content="IE=edge"/>?

When folding the window drops to the bottom. Not a big deal.
But clicking the bar to unfold the window it doesn't restore the height and the width increases by a small amount.

Only clicking the layer selects it. Seems to be some events that doesn't bubble up properly.

I see this on OSX and Windows.

This code could use some better checking or exception handling.

Check if the file actually exists before attempting to delete it - this will help keep the Ruby Console messages to a minimum.

There may be other reasons an existing file could not be deleted where you want to show a message, but also show the actual Exception for debugging.

http://helpx.adobe.com/en/photoshop/using/layer-comps.html

The "Podium not installed" dialog pops up on OSX, even though Podium is installed. SU seems to crash in this case.

I see you have a few rescue statements in the root file. Normally you want to resecue the errors you expect. And certainly avoid rescuing Exception errors and instead rescue only errors based on StandardError.

http://stackoverflow.com/questions/10048173/why-is-it-bad-style-to-rescue-exception-e-in-ruby

Some characters are replaced.
Maybe other alphabet as well.

When it opens it flickers and then disappear. I found it behind the SU window. I assume there is code to set the focus back to the SU window - which causdees problems under OSX if the window is not displayed using show_window.

The options panel changes have no effect.
The JS bridge was in fact not implemented for the options and warning panels. I'm on it.

http://sketchucation.com/forums/viewtopic.php?f=323&t=53906&p=501913#p501913

For now, all the selected items are dropped, but only one follows the mouse when dragging.

We discovered recently a bug in SketchUp where using set_attribute with an empty string as key the model would become corrupted. If saved the model would not be able to be opened again - the user would be a "Unexpected File Format." dialog upon trying to read it.
This also affect values that evaluates to empty strings, such as nil.

Since nil evaluates to empty string it's easy for this to manifest if some part of the code return nil on failure and once doesn't expect it.

We have fixed this issue in set_attribute in the next release of SketchUp (post 2014). But it means this issue is wide open on older versions.

A couple of days ago we noticed a thread on our forums where a user had had just that dialog:
http://forums.sketchup.com/t/the-dreaded-unexpected-file-format/1026

Our team investigated it and found that set_attribute had been the culprit. We where also able to identify the extension (or with high probability) that it was Layer Panel. From what I'm told in this case it was empty key on an attribute on a Page. But this issue would appear regardless on wherein the model it is set.

I would recommend that you create a wrapper around set_attribute where you validate the key being set.
The section or value is not affected by this issue.

Enhance the debug dialog to take groups in account

Found this: <input id="serialize" value="" style="display:none"/>

Instead of using CSS styling I'd recommend to use the type attribute:

LP seems to have problems with OSX MDI. It needs to be tracking models.
http://sketchucation.com/forums/viewtopic.php?f=180&t=53265
http://sketchucation.com/forums/viewtopic.php?f=180&t=43219