jimpick / lambda-comments Goto Github PK

An anonymous commenter reported a problem with Korean characters:

We're getting a "QuotaExceededError: DOM Exception 22" error.

http://stackoverflow.com/questions/21159301/quotaexceedederror-dom-exception-22-an-attempt-was-made-to-add-something-to-st

It looks like storing things in localStorage is a no-no.

Hi Jim,

My name is Vam. I live in Beijing, China. First of all, I want to say - thank you very much!! I am so so excited when I found your work - It is exactly what I need and it is amazing! You know that Disqus and many other popular sites are blocked in China for some reasons. And I want to have a simple commenting system that can be accessed from China and all over the world. I spent a lot of time tried to find a right one but I didn't. Until I see your Lambda-comments. And I agreed with your point of view from "Introducing lambda-comments". I just integrated it. Please have a look:

http://vamworks.com/2016/paintings-and-drawings-by-me-before-2016/

However, during the process I got a problem: when I create a stack via the command:

npm run create-cloudformation

I saw this message when I check my AWS CloudFormation console:

console of CloudFormation: ROLLBACK_COMPLETE

When click the stack name, I see the following problem from log:

Logical ID:

QueueCommentLambdaFunction

Status reason:

The runtime parameter of nodejs is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs4.3) while creating or updating functions.

I spent some time to did research and finally I found the answer:

http://docs.aws.amazon.com/cli/latest/reference/lambda/create-function.html

In lambda-comments.json, line 145 and 181, change "nodejs" to "nodejs4.3".

After that, it works very well!

:)

Best Regards,

Vam

Somebody posted a comment that was very long...

Hello, first of all thank you for your work. Second, I successfully deployed API and lambda functions and embed the javascript (without the akismet option). First with Node 6.0.0 then I tried with Node 6.2.2, both on OSX. Npm always runs test successfully but the only thing that appears in my page are these divs

div id="lambda-comments"
div data-reactid=".0"

so no comment form. No CORS errors in the browser. Apparently it is a frontend problem.

I also tried on a Linux VM with Node 5.7.0 (with and without sudo) and test fails (sometime it even fails during the install, running BootstrapCommand.execute when linking lambda-comments-utils dependencies). In this VM I am building without the akismet API key as well.

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture: [email protected]
Lerna v2.0.0-beta.9
Linking all dependencies
Errored while running BootstrapCommand.execute
Error: Command failed: npm install [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.>

at ChildProcess.exithandler (child_process.js:202:12)
at emitTwo (events.js:100:13)
at ChildProcess.emit (events.js:185:7)
at maybeClose (internal/child_process.js:827:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)> 

npm ERR! Linux 4.4.14-24.50.amzn1.x86_64
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "install-all"
npm ERR! node v5.7.0
npm ERR! npm v3.10.6
npm ERR! code ELIFECYCLE
npm ERR! [email protected] install-all: npm install && lerna bootstrap && linklocal
npm ERR! Exit status 1

but if I re-run it successfully bootstrapps. And this is my test

passing (66ms)
8 failing>

1. local Post new comment to the queue should return an id:
   TypeError: this is not a typed array.
   at Function.from (native)
   at Context. (test.js:33:29)>

2. local Post new comment to the queue should fail if there is no data:
   TypeError: this is not a typed array.
   at Function.from (native)
   at Context. (test.js:55:29)>

3. local Post new comment to the queue should catch spam:
   TypeError: this is not a typed array.
   at Function.from (native)
   at Context. (test.js:90:29)>

4. local Post new comment to the queue should fail with a bad signature:
   TypeError: this is not a typed array.
   at Function.from (native)
   at Context. (test.js:124:29)>

5. local Post new comment to the queue should allow posting hangul characters:
   TypeError: this is not a typed array.
   at Function.from (native)
   at Context. (test.js:159:29)>

6. remote Post new comment to the queue should return an actionRef:
   TypeError: this is not a typed array.
   at Function.from (native)
   at Context. (test.js:214:29)>

7. remote Post new comment to the queue should fail if there is no data:
   TypeError: this is not a typed array.
   at Function.from (native)
   at Context. (test.js:224:29)>

8. remote Post new comment to the queue should allow posting hangul characters:
   TypeError: this is not a typed array.
   at Function.from (native)
   at Context. (test.js:252:29)>

Any suggestion?

Tried to use today and everything worked until I got to the npm run test. Getting the following error:

1 failing

1. local Post new comment to the queue should catch spam:
   Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test

npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/Cellar/node/6.2.1/bin/node" "/usr/local/bin/npm" "run" "test"
npm ERR! node v6.2.1
npm ERR! npm v3.10.5
npm ERR! code ELIFECYCLE
npm ERR! [email protected] test: mocha --compilers js:./babel-register
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test script 'mocha --compilers js:./babel-register'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the lambda-comments package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! mocha --compilers js:./babel-register
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs lambda-comments
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls lambda-comments
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /Users/jbrodley/lambda-comments/npm-debug.log

from Debug log.

sxjbrodmbp:lambda-comments jbrodley$ vi /Users/jbrodley/lambda-comments/npm-debug.log

11 silly lifecycle [email protected]test: Args: [ '-c', 'mocha --compilers js:./babel-register' ]
12 silly lifecycle [email protected]test: Returned: code: 1 signal: null
13 info lifecycle [email protected]~test: Failed to exec test script
14 verbose stack Error: [email protected] test: mocha --compilers js:./babel-register
14 verbose stack Exit status 1
14 verbose stack at EventEmitter. (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:242:16)
14 verbose stack at emitTwo (events.js:106:13)
14 verbose stack at EventEmitter.emit (events.js:191:7)
14 verbose stack at ChildProcess. (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack at emitTwo (events.js:106:13)
14 verbose stack at ChildProcess.emit (events.js:191:7)
14 verbose stack at maybeClose (internal/child_process.js:852:16)
14 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
15 verbose pkgid [email protected]
16 verbose cwd /Users/jbrodley/lambda-comments
17 error Darwin 15.6.0
18 error argv "/usr/local/Cellar/node/6.2.1/bin/node" "/usr/local/bin/npm" "run" "test"
19 error node v6.2.1
20 error npm v3.10.5
21 error code ELIFECYCLE
22 error [email protected] test: mocha --compilers js:./babel-register
22 error Exit status 1
23 error Failed at the [email protected] test script 'mocha --compilers js:./babel-register'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the lambda-comments package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error mocha --compilers js:./babel-register
23 error You can get information on how to open an issue for this project with:
23 error npm bugs lambda-comments
23 error Or if that isn't available, you can get their info via:
23 error npm owner ls lambda-comments
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

Hey there, congrats on reaching the front page of HN!
A colleague pointed out that you're using a forked version of my akismet-api library, I'm glad it's useful for building this. I was curious about the changes and I noticed you just updated superagent.

I had an issue for that here, but superagent changes the way it passes around errors in 1.0 so I had to do some additional testing to make sure everything was good.

I just released a new version (2.1.0) that supports superagent 1.8.3, so you might want to consider using the root akismet-api package again! If you have any other suggestions for the library, feel free to make an issue or pull request!

After I enable the frontend I get:

GET https://s3-eu-central-1.amazonaws.com/myblogcomments-../comments.json 403 (Forbidden)

And when posting:

"Fetch API cannot load https://xxx.execute-api.eu-central-1.amazonaws.com/prod/comments. Response to preflight request doesn't pass access control check: The 'Access-Control-Allow-Origin' header has a value 'https://www.website.org' that is not equal to the supplied origin. Origin 'http://www.website.org' is therefore not allowed access. Have the server send the header with a valid value, or, if an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled."

I can't seem to be able to change from https to http, any hint on how to change it?

https://twitter.com/jimpick/status/728616124229648384

And is this still maintained?

sudo npm run install-all gives:

npm ERR! Linux 3.13.0-74-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "install-all"
npm ERR! node v6.1.0
npm ERR! npm  v3.8.6
npm ERR! code ELIFECYCLE
npm ERR! @jimpick/[email protected] install-all: `npm install && cd packages/frontend && npm install`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @jimpick/[email protected] install-all script 'npm install && cd packages/frontend && npm install'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the @jimpick/lambda-comments package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm install && cd packages/frontend && npm install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs @jimpick/lambda-comments
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls @jimpick/lambda-comments
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! Please include the following file with any support request:
npm ERR!     /home/ubuntu/lambda-comments/npm-debug.log

sudo npm install on its own gives:

npm ERR! Linux 3.13.0-74-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v6.1.0
npm ERR! npm  v3.8.6                                                                      npm ERR! code E404

npm ERR! 404 Not found : @jimpick/akismet-api
npm ERR! 404                                                                              npm ERR! 404  '@jimpick/akismet-api' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of '@jimpick/lambda-comments'               npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/ubuntu/lambda-comments/npm-debug.log

Something tells me that this may have to do with the recent security upgrade to 6.x and the apparent phasing-out of 5.x.

Entering spaces as content, or anything that will render to an empty markdown section is currently permitted.

Add some checks to ensure that the markdown renders out to something.

Apparently this is a known error between the version of Node on AWS Lambda and DynamoDB.

Possible fix:

https://twitter.com/thealphanerd/status/731161851438845952

Hello - is this in use anywhere that I can take a look?
Kind regards

In my .env:

REGION=ap-southeast-2

then I ran npm run create-cloudformation. But the cloudformation stack got created in us-west-2.