jinhe1314 / broadcom-bluetooth Goto Github PK

What steps will reproduce the problem?
1. Do a hard reset AP6210 chip or BCM2048, for example.
2. Try to load firmware (brcm_patchram_plus) using hardware uart (not usb) 
interface.

To properly initialise chip's uart interface you must "twich" CTS line 
(HIGH->LOW->HIGH) before sending any data to them.
It may be done by opening appropriate port, pause (some msec) and then close 
port.

During use with the option enable_hci the program waits for almost infinite:

        if (enable_hci) {
                proc_enable_hci();

                while (1) {
                        sleep(UINT_MAX);
                }
        }

UINT_MAX is a very big value.

While ending the program with ^C after the message "Done setting line 
discpline" seem to be working fine.

Is the sleep really requered ? 

Please add an --retries option.

If the chip isn't ready to receive the firmware the patch command keeps trying 
to update in an endless loop.
It would be nice if the program would end after 'N' tries with an exit code.
For example an '--retries 5' option at the command line for max 5 retries.

If the patch command is used in a script this way it provides for a nice way of 
detecting if the command was successful.

Branch name:

h5_sync_retry

Purpose of code changes on this branch:

Add sync retries to the H5 sync phase.

When reviewing my code changes, please focus on:


After the review, I'll merge this branch into:
/trunk