jintin / andle Goto Github PK

Running the script gives the following line:
buildToolsVersion: 23.0.2 -> android-4.4W

This should not be suggested, 23.0.2 is the newest version of the build tools.

When checking for the latest version of Gradle the script does not ignore the "distributionUrl: " portion of the line, resulting in a false positive.

distributionUrl: https\://services.gradle.org/distributions/gradle-2.9-all.zip -> https\://services.gradle.org/distributions/gradle-2.9-all.zip

In react native it generate old sdk number, etc
https://react-native.canny.io/feature-requests/p/update-android-build-tools-version-in-project-generated-by-react-native-init
I wonder if you can add a guide to update react native gradle and dependencies modules.

andle will fail if dependency path does not exist

file: andle/sdk.py
see the following lines

 40    ...
 41     find_dependency(data["dependency"], "", path + "/extras/android/m2repository")
 42     find_dependency(data["dependency"], "", path + "/extras/google/m2repository")
 43    ...

My configuration does not have "..../extras/google/m2repository"

It's a good idea to check if the path exists in find_dependency function before modifying anything in data

e.g.

 52 
 53 def find_dependency(data, tag, path):
 54     if os.path.exists(path):
 55         no_dir = True
 56         for f in os.listdir(path):
 57             if (os.path.isdir(path + "/" + f)):
 58                 no_dir = False
 59                 find_dependency(data, tag + "/" + f, path + "/" + f)
 60         if no_dir:
 61             list = tag[1:].split("/")
 62             version = list.pop(len(list) - 1)
 63             name = list.pop(len(list) - 1)
 64             package = ".".join(list)
 65 
 66             update_value(version, data, package + ":" + name)
 67 

andle setsdk -p /Users/osrl/Library/Android/sdk
andle setsdk --help
andle --version
returns "set sdk path first"