multiple issues

ASM doesn't compile with required flags

sources/asm/encoding.c:92:31: error: unused parameter 'target' [-Werror,-Wunused-parameter]
char    *save_name_comment(char *target, int source_fd, char *line)
                                 ^
sources/asm/encoding.c:116:11: error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
        else if (line[cnt] == '\"')
                 ^~~~~~~~~~~~~~~~~
sources/asm/encoding.c:118:33: note: uninitialized use occurs here
        return (remove_trailing_spaces(ret));
                                       ^~~
sources/asm/encoding.c:116:7: note: remove the 'if' if its condition is always true
        else if (line[cnt] == '\"')
             ^~~~~~~~~~~~~~~~~~~~~~
sources/asm/encoding.c:94:11: note: initialize the variable 'ret' to silence this warning
        char    *ret;
                    ^
                     = NULL
2 errors generated.
make: *** [objects/asm/encoding.o] Error 1

-dump nbr_cycles

at the end of nbr_cycles of executions, dump the memory on the standard output
and quit the game. The memory must be dumped in the hexadecimal format with
32 octets per line.

allowed characters are defined in op.h as: LABEL_CHARS

issue example:

.comment "b"
.name "a"
# paskuda tvar
jopa&:
live %1

should spit an error.

original behavior example:
Lexical error at [4:5]

multiple issues

If Assembler exits with error it still creates an empty .cor file.

Suggest to move relevant creation lines of target file from init.c initialize_asm function to to_bytecode.c write_champion function.

Needs to be replaced with a function that writes the error to stderr fd

multiple norm issues

Norme: ./sources/vm/vfx_utils.c Warning: /Users/jnovotny/Hive/corewar/sources/vm/vfx_utils.c may not compile or is invalid for some reasons.

Needs to be tested on schools mac.

champ lies about weighing 0 bytes :)

multiple issues

doesn't work xD

if live argument is a valid player, it needs to save it to core->last_player

Subjects requires the ability to assign number to each player manually

no need of player_id?

After cloning a carriage, it should be prepend to the car_list as subject mentions:

The instructions ending at the same cycle will execute themselves in in decreasing order of the processes’ number.

Therefore newest carriage should be always at the beginning of the list

• when reporting "live" the vm needs to check if given argument is a valid player, if yes saves his index in core->last_live
• when game ends the winner is announced and program exits cleanly
• what if none reports live?

“Player X (champion_name) won”

Champion number range, investigate and implement

How to deal with wrong registry call? e.g. r50 as argument. Ignore, skip, error?

Should it continue reading for the exec code or just spit error?

According to norminette any used global variable has to be prefixed with g_. So the global variable

static const	t_oplist	oplist[16];

in oplist.h needs to be changed to:

static const	t_oplist	g_oplist[16];

For each valid execution of the live instruction, the machine must display:

“A process shows that player X (champion_name) is alive”.

After cloning a carriage, it should be prepend to the car_list as subject mentions:

The instructions ending at the same cycle will execute themselves in in decreasing order of the processes’ number.

Therefore newest carriage should be always at the beginning of the list

asm segfaults if either .name or .comment is missing completely.

example:

.comment "comment"

# paskuda tvar
live %1

Needs investigation whether works properly

jani's slack msg:

I think there might be an issue with the carry flag as well. I'm running championship 2014 champs to learn stuff and many of them just skip zjmp instructions in their code and end up doing nothing. I don't know if the rules and carry flag changed over the years but for example 2014/gleger/Machine_gun.s has multiple obvious zjmp loops but the carriage just gets away during the game.

In asm, the .name string and .comment string should be limited by PROG_NAME_LENGTH and COMMENT_LENGTH respectively.

original asm response example:
Champion name too long (Max length 128)

flag that would allow to load champ that is bigger than CHAMP_MAX_SIZE. Only if it's possible to fit all players in (sum < MEM_SIZE)

In case of an error, you must display a relevant error message on the standard error
output.

Ensure that the (every and last) operation in .s must always end with a newline for a correct translation.