jjj / ab-testing-for-wp Goto Github PK

To prevent #53 from happening again, we need to add e2e tests to cover the integrations too.

Would be interesting to install 3th party plugins during e2e tests, but I guess it can be done.

Got a question / bug report though mail:

Hi Gaya,

I use your A/B Testing for WordPress plugin, and I appreciate your great work!

I'll report a bug to you.

When I use Japanese text in the button, the text was garbled with A/B testing plugin.

Example:
https://drive.google.com/open?id=18RmRRKqpEJT9OKNUN1V016YplM1bnDl7

This is purely from a technical standpoint. We should not be using any in any condition.

Create end-to-end tests which can be executed in the CI

There are situations where pre-rendering variants in PHP will not work when there are caching plugins involved. The caching mechanism would be the one determining the variant instead of the user.

An option to always have JavaScript determine the variant would be better.

This could be done over XHR.

Hi,

The integrations reference to the trackPostId method (from class ABTestTracking) which no longer exists. If I look at the commit history, it appears it has been replaced by trackGoal.

I have seen this causing a fatal error on form submits with GravityForms. But the method is also used in other integrations, so I imagine the same issue there.

I would submit a pull request, but I'm not entirely sure if the only changing the method to trackGoal would fix since I am not familiar with what needs to be done when trackPostId is called.

When no test on page is present, admin bar makes invalid request through XHR

Looks of the new Gutenberg nested block padding looks pretty messy starting WordPress 5.3

The list is always empty, even after adding, saving and publishing the test. It is still accessible through URL. Also not visible on any other listing (pages, posts, comments, etc.).

Not sure if it is connected, but then on a page, I get this error in the console:

Since the development is still quite early, we can move over to TypeScript quite easily still.

Have to see how well it plays with WordPress' type definitions though, but it shouldn't be a problem.

Perform linting and static analysis on pull requests

Please consider moving ab-testing-for-wp.zip file to releases
Of course there must be tagged releases to attach files to them :)

It could be completely removed https://help.github.com/en/github/authenticating-to-github/removing-sensitive-data-from-a-repository making the repository much smaller.

@Gaya Do you plan to add proper PHPDoc blocks to methods and properties?

@Gaya Could it that you use your @gmail.com - non-GitHub - address in your git client?

When adding an A/B test block, I can't seem to add of change anything on initial load and the default content isn't present:

I'm getting a Missing test parameter in the console.

When I do a full page refresh everything works.

Here is a video breakdown:

https://www.loom.com/share/64ac1e0516f544e6a82603d27b1df63b

Due to recent changes to the Wordpress Rest API the following warning is shown:

Notice: register_rest_route was called incorrectly. The REST API route definition for ab-testing-for-wp/v1/ab-test is missing the required permission_callback argument. For REST API routes that are intended to be public, use __return_true as the permission callback.

Plugin version: 1.18.2
Wordpress version: 5.5.1

Once 10up/action-wordpress-plugin-deploy#22 has been merged and released, switch back to using the official one instead of the fixed forked version.

It would be really nice to have GitHub actions release the plugin using tags.

When a version is tagged it will create a release for GitHub and update the plugin in the WordPress SVN repository.

Also see #20