jleagle / php-packages.com Goto Github PK

Currently, an author is identified by its email address and deduplicated. However, this is wrong:

• the email is optional for authors in Composer, and it is often the case when adding the community as an author with a link to the list of contributors on github or elsewhere (I know many packages doing it, including Symfony). Any author without email is currently missing in the display as it is ignored in https://github.com/Jleagle/reverse-packagist/blob/a6e543516e455070ef525f81359072b82f118d32/app/controllers/PackagesController.php#L269 (Packagist only ignores authors when both the email and the name are missing, allowing to support this use case, so your site should do the same)
• the same email address can be associated to different properties in different packages. In particular, the role property is likely to change from package to package. Packagist suffered from this bug as well, but this has been fixed in composer/packagist@b1fdc21

See http://packages.jimeagle.com/package/asgard/console for such a link on the Repo button.

there is 2 things you should do:

• fix links to github repos, as done by Packagist as the way to create links is known here
• prefer the link to the source available in the support section of the package over the repo url when it is provided, as it is the way for packages to give the url of their source viewer when it is different than the repo url (which can happen often given that one is for an HTML page showing the repo content and the other one is for git access)

See http://packages.jimeagle.com/package/wookieb/zorro-data-schema for instance. the author name displays ? instead of unicode chars. I see 2 possible reasons:

• the content may be broken in your database, not storing it as UTF-8
• the escaping might be broken in your templates, escaping with a different charset than UTF-8

it uses a select with no options in it at all, which makes the field useless