Giter VIP home page Giter VIP logo

Comments (3)

jlfwong avatar jlfwong commented on May 11, 2024 1

I agree with all of the details you suggested!

from speedscope.

alangpierce avatar alangpierce commented on May 11, 2024

I'll try taking this on, I think it shouldn't be so bad. I also would like a hash param to give a custom title at the top of the flamechart. One use case is an iframe embedded in a chrome dev tools panel, and another use case is opening a flamechart as an external link. In both cases, the URL is to an S3 file with an encrypted access key, and the profile is slightly sensitive (contains function names from my company's internal codebase), which is why it needs to be a hash fragment and never sent to the server. The S3 file has a standard/autogenerated name that isn't very meaningful, which is why I want the Chrome extension to be able to give a custom title, since it has more context.

Some details/bikeshedding:

  • I vaguely prefer camelCase query params and was thinking profileURL (it doesn't really feel like an import, at least in my context; you're just using speedscope to view that particular flamechart). But I'm also cool with kebab-case.
  • I'm thinking it should be ampersand-delimited with URL-encoded values, just like query params, e.g. https://jlfwong.github.io/speedscope/#profile-url=http%3A%2F%2Fwww.google.com&title=My%20cool%20profile. Seem reasonable?
  • I think it would be best to best to view it as a special mode that doesn't show the intro screen even for the initial render.

from speedscope.

jlfwong avatar jlfwong commented on May 11, 2024

Fixed by #19

from speedscope.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.