Giter VIP home page Giter VIP logo

funforfido's Introduction

Jason Matzke Individual Project

Problem Statement

I want to make a website to find dog parks easier and be able to search for them, add your own pictures from them and make comments. I will have the ability to add park you have been to or search for them through a google map search. In the future, blog capabilities, photo albums and video addition will be added to the member services.

##Techologies Used

  • MySql / Hibernate
  • Bootstrap
  • Google Web Services (places and geocoding for now)(independent research)
  • Log4J
  • Jenkins (independent research)
  • Openshift
  • Javascript API
  • jQuery

Contiuning possible future add-ons to application

  • JSF - newer version of jsp's
  • mongoDb - very easy to store responses if I need to
  • store image paths in database

##Project Plan Project Plan

##Journal Development Journal

funforfido's People

Contributors

jmatzke1 avatar

Watchers

James Cloos avatar avatar Paula Waite avatar

funforfido's Issues

Project Review

Design/Code Review 1

Project:

Developer:

Reviewer:

Category Criteria Rating/Comments
Problem Statement Does it exist? Yes
Does the problem statement accurately describe project purpose? Yes
Is the problem statement professional? Think of prospective employers viewing this as part of the developer's portfolio. OK
What is good? Yes
What could be improved? Looks good. Needs more detail? Perhaps with the linked sections you could put a brief description with the link...
Project Plan Does it exist? Yes
Does it demonstrate the developer has thought about all the tasks needed to complete the project? Yes
Does it provide enough detail to guide the developer through their development? Through at least most of it.
What is good? Yes
What could be improved?
UI design Does it exist? Yes
Is the navigation/flow through the application logical and easy to use? Yes
Is the order in which the fields are displayed and form fields entered logical and easy to use? Yes
What data missing?
Is there data that is not used?
What is good? There are several pages to your website that you produced a nice wireframe for. I could easily follow the logic in the design. I especially like the "Something I will think of button!"
What could be improved?
Data model Does it exist? Yes
Is everything on the screens represented in the model? Yes
Does the model represent good database design? So far...need to link a couple more tables
What is good? Ys
What could be better? Just need to get that Park and ParkInfo entity tables to link together!
Additional design documents
Application structure in IntelliJ Does it exist? Yes
src directory with well-named packages for entity, controller, persistence
tests directory
web directory Yes
Other comments/notes?
JSPs Do they exist? Yes
Is templating used (for example, header.jsp, footer.jsp, etc.)?
Is there business logic mixed in the JSPs?
CSS?
Other comments/notes?
Entities/DAOs/Controllers Do they exist?
Java code quality Are methods single-purpose?
Are classes appropriately-sized classes (no monster classes)?
Are the same lines of code repeated at all?
Do any classes perform very similar functions that could be candidates for super/subclass relationships?
Are any values hard-coded that should be in a properties file?
Are variable names descriptive?
Are there many branches or loops that could be simplified or broken up into smaller methods?
Do the DAOs use Hibernate? No hard-coded sql!
Other comments/notes?
Logging Has log4J been added?
Are there logging statements in the code?
Are appropriate logging levels used? Info, debug, error, for example.
Are there any System.out.printlns in the code?
Other comments/notes?
Unit Tests Do they exist?
Do the tests pass?
What is the current code coverage?
Is each test truly a unit test or are they functional tests?
Other comments/notes?
Web Service/API integration Has a web service/api been selected?
What web services/apis might work well with this application?
Independent research topic Has a topic been selected?
What topic/s might fit well in this application?
Reviewers Addtional Comments Comments: Great start to your project. Well organized wireframes! Can't wait to see how you fix the slide bar "issue" for the Google Maps section. I will also be interested in finding out how you get the particular Goggle Maps features to work as a mobile app (even if this happens in the future).

Code Review 3

Design/Code Review 3

Project: Fun For Fido

Developer: Jason Matzke

Reviewer: Nancy Adam

Category Criteria Rating/Comments
Project Overview
Does the application function as planned and designed? Are all project objectives met? Y
Does the GitHub history show regular progress on the project Y
Was peer and instructor feedback/recommendations incorporated into the project?
Other comments/notes?
JSPs
Is templating used (for example, header.jsp, footer.jsp, etc.)? Y
Is there business logic mixed in the JSPs? N
Does the site look professionl? Is it portfolio worthy? Y
Is there validation of user input?
Other comments/notes? Great job so far on how the site looks with using bootstrap themes!
Java code quality Are methods single-purpose? Y
Is the project well-structured with well-named packages for entity, controller, persistence, etc.? Y
Are classes appropriately-sized (no monster classes)? Y
Are the same lines of code repeated at all? N
Do any classes perform very similar functions that could be candidates for super/subclass relationships? Y
Are any values hard-coded that should be in a properties file?
Are best practices for naming variables, methods and classes followed? Y
Are there many branches or loops that could be simplified or broken up into smaller methods? N
Do the DAOs use Hibernate? No hard-coded sql! Y
Do the DAOs use Hibernate criteria wherever possible, minimizing the use of HQL? Y
Is proper exception handling used?
Is the code docmented appropriately?
Other comments/notes?
Logging Has log4J been added? Y
Is there an appropriate number of logging statements in the code for error logging and debugging? Y
Are appropriate logging levels used? Info, debug, error, for example. Y
Are there any System.out.printlns or printstacktrace() in the code? Y
Are the logs properly written when running as a web application? Y
Other comments/notes?
Unit Tests Do they exist? Y
Do the tests pass?
What is the current code coverage?
Is each test truly a unit test or are they functional tests?
Is redundant code eliminated by using set up and tear down methods, i.e., @before, @after?
Other comments/notes?
Security Has authentication/authorization been implemented?
Are there some resources that only certain users can access?
Are there some resources that everyone can access? Y
Other comments/notes?
Web Service/API integration Which services/apis have been implemented? In progress of working with Google maps
Is the service SOAP or RESTful?
Are java objects created from the service response?
Is the service used effectively in the project? In Progress
Does the service implementation include error handling? For example, What happens if the service is not available?
Other comments/notes?
Independent research topic What is the independent research topic? In Progress
Is the independent research topic/technique implemented in the project?
Other comments/notes?
Deployment Has the application been successfully deployed to Openshift or another hosting service? N
Is the hosted application fully functioning?
Other comments/notes?

Code Review 3

Design/Code Review 3

Project: YouDeserveBetterToday

Developer: Nancy Meister

Reviewer: Brian Woestman

Category Criteria Rating/Comments
Project Overview
Does the application function as planned and designed? Are all project objectives met? Yes
Does the GitHub history show regular progress on the project Yes
Was peer and instructor feedback/recommendations incorporated into the project? Yes
Other comments/notes? N/A
JSPs
Is templating used (for example, header.jsp, footer.jsp, etc.)? Yes
Is there business logic mixed in the JSPs? No
Does the site look professionl? Is it portfolio worthy? Yes
Is there validation of user input? Yes
Other comments/notes? N/A
Java code quality Are methods single-purpose? Yes
Is the project well-structured with well-named packages for entity, controller, persistence, etc.? Yes
Are classes appropriately-sized (no monster classes)? Yes
Are the same lines of code repeated at all? No
Do any classes perform very similar functions that could be candidates for super/subclass relationships? No
Are any values hard-coded that should be in a properties file? No
Are best practices for naming variables, methods and classes followed? Yes
Are there many branches or loops that could be simplified or broken up into smaller methods? None
Do the DAOs use Hibernate? No hard-coded sql! Yes / No hardcoded values
Do the DAOs use Hibernate criteria wherever possible, minimizing the use of HQL? Yes
Is proper exception handling used? Yes
Is the code docmented appropriately? Yes
Other comments/notes? N/A
Logging Has log4J been added? Yes
Is there an appropriate number of logging statements in the code for error logging and debugging? Yes
Are appropriate logging levels used? Info, debug, error, for example. Yes
Are there any System.out.printlns or printstacktrace() in the code? No
Are the logs properly written when running as a web application? Yes
Other comments/notes? N/A
Unit Tests Do they exist? Yes
Do the tests pass? Yes
What is the current code coverage? 35%
Is each test truly a unit test or are they functional tests? Yes
Is redundant code eliminated by using set up and tear down methods, i.e., @before, @after? Yes
Other comments/notes? N/A
Security Has authentication/authorization been implemented? Yes
Are there some resources that only certain users can access? Yes
Are there some resources that everyone can access? Yes
Other comments/notes? N/A
Web Service/API integration Which services/apis have been implemented? Working through Google maps usage for Java
Is the service SOAP or RESTful? No
Are java objects created from the service response? N/A
Is the service used effectively in the project? N/A
Does the service implementation include error handling? For example, What happens if the service is not available? N/A
Other comments/notes? N/A
Independent research topic What is the independent research topic? Google maps API
Is the independent research topic/technique implemented in the project? Not yet
Other comments/notes? N/A
Deployment Has the application been successfully deployed to Openshift or another hosting service? No
Is the hosted application fully functioning? No
Other comments/notes? N/A

Instructor Feedback Week 15

Hi Jason, Things are coming along! I wanted to share a few suggestions for improvements before we reach code complete date:

  • Project plan, time log, journal - started off strong here, but missing more current info.
  • Consider updating the problem statement to introduce the project now that it is closer to completion. Think about prospective employers reviewing your portfolio - this will be the first page they see when looking at your repository. Also note the link under Design is broken.
  • There are a couple occurrences of e.printStackTrace(); - remember log4j
  • If there is an error (connecting to the database for example), what is the user experience? Error page?
  • Good use of jsp templating - could the "<%@ page contentType="text/html;charset=UTF-8" language="java" %>" that appears on each page be included in a template as well?
  • When you run your application as a web application, where do your logs go?
  • Feel free to delete your Database class, any non-hibernate daos, and any other classes you don't use (you can always get them back from the repo if needed)
  • Just in case you forget it is there, in the MemberDAOHibernate: member.setZipCode("43245");
  • Tests - more needed
  • Web service implementation?

Instructor Feedback Week 4

Looks like you've laid some great ground work with your project and I enjoyed sitting in on your review on Thursday. I like the project planning you've done so far - looks like now it is time to begin updating based on what's completed and look into adding more detail for the next few weeks. How is building out the database going? Did you gain some traction on the weeks 3 and 4 plan?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.