Giter VIP home page Giter VIP logo

Comments (3)

marip8 avatar marip8 commented on June 5, 2024

We should move forward with the changes to rct_optimizations and rct_image_tools sooner rather than later. Our current development efforts may make it difficult to reconcile those packages (at least rct_optimizations) if we wait too long

from robot_cal_tools.

schornakj avatar schornakj commented on June 5, 2024

@marip8 It looks like we're halfway through this, since rct_optimization and rct_image_tools are pure-CMake packages now. Seems like a good time for us to strategize.

What do you think would be a good way to handle rct_ros_tools? The two important parts of that package are:

  • The target loader utilities, which take a ROS1 nodehandle to load target properties from parameters.
  • The command line cal app, which is a standalone node that interacts with the parameter server and performs TF lookups.

I was originally thinking that some parts (e.g. the data_set library) could be moved into the non-ROS part of this repo, but on further investigation they ultimately depend on ROS parameter loading so that might not be feasible.

For the time being I'm going to make a separate repo for my current ROS2 port of rct_ros_tools, since I'd like to take advantage of the improvements we made this summer to the core calibration libraries without being blocked by this.

from robot_cal_tools.

marip8 avatar marip8 commented on June 5, 2024

I think we could move the data and target loading functions into rct_image_tools since they primarily deal with loading targets and images. I believe yaml-cpp and xmlrpcpp are both ROS-independent C++ packages that could be used in a ROS1 or ROS2 context, so we could probably just revise the parameter loader utilities to deal in terms of those objects and string filepaths rather than ROS1 node handles

from robot_cal_tools.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.