jmsadair / raft Goto Github PK

Hello,

I came across this repo and the simplicity/flexibility really inspired me to switch from hashicorp/raft in my Distributed API Gateway at dgate-io/dgate; There were a few other reasons, but I will spare you the details.

I plan to create a cluster that spans across the globe (I am aware of the potential low latency/throughput). And I am wondering why there are min/max restrictions on the election timeout, heartbeat and lease values and if there are any potential issues that you foresee if they were to be increased.

These values seem very low even for a regional deployment of some key/value database.

• Task: Misspelled interface function:
  RegsiterInstallSnapshotHandler -> RegisterInstallSnapshotHandler

• Task (optional): Interface name change:
  Log -> LogStore - just a nitpick in naming
  type Log = LogStore - you can use an alias type and add deprecated to the godoc for backwards compatibility.

• Task: For the Log interface, can you add more context and information to the godoc on the follow functions and how they are used: Truncate, Compact, Contains, DiscardEntries. DiscardEntries's description is okay, but having more concrete and clear explanations like: this function is used when a snapshot is taken and earlier logs are no longer needed.

This implementation assumes that the address that is being listened on (e.g. 0.0.0.0:1234), is the same address that other nodes will use to connect. This is usually the case for testing locally, but in staging/production, it's common to use domain names, and/or different addresses.

I don't think there is much to change except removing the address comparison here

To get around this, I am manually adding Transport and using the advertised address as the address variable for the NewRaft function.