jmuheim / base Goto Github PK

View Code? Open in Web Editor NEW

12.0 12.0 7.0 4.38 MB

Pre-configured basic Rails project which aims to initialize a new project fast and painless - simply fork it!

Ruby 71.63% CoffeeScript 7.37% Shell 0.07% JavaScript 5.67% Sass 6.89% Slim 8.38%

base's People

Contributors

Stargazers

Watchers

Forkers

stevegriffin pulkit21 retoinniger backflip mtsmfm gurix

base's Issues

Missing blank in confirmation instructions mail

There should be a blank between "Welcome" and the email address:

We should consider using markdown instead of plain SLIM here...

Add info to notice flash that signed user is logged in automatically

A screenreader user may not be aware of this automatically.

Text could be: "Welcome! You have signed up successfully. You are logged in now."

Refactor specs to resemble new RSpec.describe syntax

Before:

require 'rails_helper'

describe UsersController do
  describe 'routing' do
    it 'routes to #index' do
      expect(get('/users')).to route_to('users#index')
    end

Now:

require "rails_helper"

RSpec.describe BoilerplatesController, type: :routing do
  describe "routing" do

    it "routes to #index" do
      expect(:get => "/boilerplates").to route_to("boilerplates#index")
    end

Display email in users#index and users#show only to admins

Selected menu group is visually not perceivable enough

Contrast is too low.

Inaccurate flash alert when requesting new password

"Close" button in alerts/notices overlapping with text

Change devise reply-to mail ([email protected])

Make `driver: :chrome` work again

See http://stackoverflow.com/questions/29387097/capybara-and-chrome-driver-sqlite3busyexception-database-is-locked.

# To make chrome driver work, we need to monkey patch active record, otherwise we get an "SQLite3::BusyException: database is locked". See http://stackoverflow.com/questions/29387097.
class ActiveRecord::Base
  mattr_accessor :shared_connection
  @@shared_connection = nil

  def self.connection
    @@shared_connection || retrieve_connection
  end
end
ActiveRecord::Base.shared_connection = ActiveRecord::Base.connection

TEST

Close dropdown with esc-key when inside the menu

Here I can close it with esc:

Here I can't:

Make sure that sign up confirmation emails use the correct URL (and port)

Don't know whether this is new, but should be investigated further.

The "Confirm my account!" link in the sign up process links to port 3000, but should link to 3001.

Remove jazz_hands gem (outdated)

There doesn't seem to be any progress anymore, so we should remove it and configure our pry enhancements ourselves.

Remove guest user after logging in

Make Fancybox accessible (or remove it)

I have contacted the owner. Let's see what happens. Otherwise we should remove it, as it doesn't add "real" value than just being fancy.

Tests are run twice when running `rake`

$ rake
[deprecated] I18n.enforce_available_locales will default to true in the future. If you really want to skip validation of your locale you can set I18n.enforce_available_locales = false to avoid this message.
/Users/josh/.rvm/rubies/ruby-2.0.0-p353/bin/ruby -S rspec ./spec/controllers/dashboards_controller_spec.rb ./spec/helpers/dashboards_helper_spec.rb ./spec/views/dashboards/show.html.slim_spec.rb
[deprecated] I18n.enforce_available_locales will default to true in the future. If you really want to skip validation of your locale you can set I18n.enforce_available_locales = false to avoid this message.
 3/3 |======================================================= 100 =======================================================>| Time: 00:00:00 

Pending:
  DashboardsHelper add some examples to (or delete) /Users/josh/Documents/Work/Sientia/tests/transition/spec/helpers/dashboards_helper_spec.rb
    # No reason given
    # ./spec/helpers/dashboards_helper_spec.rb:14
  dashboards/show.html.slim add some examples to (or delete) /Users/josh/Documents/Work/Sientia/tests/transition/spec/views/dashboards/show.html.slim_spec.rb
    # No reason given
    # ./spec/views/dashboards/show.html.slim_spec.rb:4

Finished in 0.04166 seconds
3 examples, 0 failures, 2 pending

Randomized with seed 18287

/Users/josh/.rvm/rubies/ruby-2.0.0-p353/bin/ruby -S rspec ./spec/controllers/dashboards_controller_spec.rb ./spec/helpers/dashboards_helper_spec.rb ./spec/views/dashboards/show.html.slim_spec.rb
[deprecated] I18n.enforce_available_locales will default to true in the future. If you really want to skip validation of your locale you can set I18n.enforce_available_locales = false to avoid this message.
 3/3 |======================================================= 100 =======================================================>| Time: 00:00:00 

Pending:
  DashboardsHelper add some examples to (or delete) /Users/josh/Documents/Work/Sientia/tests/transition/spec/helpers/dashboards_helper_spec.rb
    # No reason given
    # ./spec/helpers/dashboards_helper_spec.rb:14
  dashboards/show.html.slim add some examples to (or delete) /Users/josh/Documents/Work/Sientia/tests/transition/spec/views/dashboards/show.html.slim_spec.rb
    # No reason given
    # ./spec/views/dashboards/show.html.slim_spec.rb:4

Finished in 0.04079 seconds
3 examples, 0 failures, 2 pending

Randomized with seed 13756

Extend i18n-tasks to search for headline_with_flash automatically

At the moment, we are using i18n-tasks-use t('.title') work-around whenever we call headline_with_flash. It would be nice to extend the i18n-tasks scanner though so we don't have to do this.

glebm/i18n-tasks#138