jmxtrans / jmxtrans-cookbook Goto Github PK

Hey, probably something you already know but version 2.0 of this cookbook is pretty broken.

I managed to get the ubuntu package install working but that was after a significant amount of massaging. I am open to cleaning some of that stuff up and getting a PR in but I don't want to step on your toes if you are working on the same branch as well.

In addition I would also like to make sure there will be a decent level of activity should I start submitting PR so they don't sit waiting for awhile. I would love to get a stable version 2 of this cookbook out there.

Some issues I ran into...

• jmxtrans now uses JAVA to determine where to access java which the default is JAVA_HOME/bin/java which creates issues as we export JAVA_HOME by default to /usr/bin/java. The java path jmxtrans attempts to use is /usr/bin/java/bin/java
• JAR_FILE was exported to the wrong location for package installs. Looks like it was still the default for non package installs. This should update dynamically based on recipe used.
• Package Install should set install prefix to /usr/share
• Can't seem to get any log information generated. It creates the log file but no log messages(NOT RESOLVED)

When first using this cookbook, if you do not previously install and configure java the execute block for update-alternatives fails.

After installing java the cookbook properly converged. I would either update the readme to specify that java needs to be managed independently from this cookbook or update the cookbook to manage a java version.

Error below...

==> chub_jmxtrans: ================================================================================
==> chub_jmxtrans: Error executing action `run` on resource 'execute[set correct jps alternative]'
==> chub_jmxtrans: ================================================================================
==> chub_jmxtrans:
==> chub_jmxtrans:
==> chub_jmxtrans: Mixlib::ShellOut::ShellCommandFailed
==> chub_jmxtrans: ------------------------------------
==> chub_jmxtrans: Expected process to exit with [0], but received '2'
==> chub_jmxtrans:
==> chub_jmxtrans: ---- Begin output of update-alternatives jps --auto jps ----
==> chub_jmxtrans:
==> chub_jmxtrans: STDOUT:
==> chub_jmxtrans:
==> chub_jmxtrans: STDERR: update-alternatives: error: unknown argument `jps'
==> chub_jmxtrans:
==> chub_jmxtrans: ---- End output of update-alternatives jps --auto jps ----
==> chub_jmxtrans:
==> chub_jmxtrans: Ran update-alternatives jps --auto jps returned 2
==> chub_jmxtrans:
==> chub_jmxtrans: Resource Declaration:
==> chub_jmxtrans: ---------------------
==> chub_jmxtrans: # In /tmp/vagrant-chef/ac8c3f11f4d0fda7770beb101dfde37f/cookbooks/jmxtrans/recipes/default.rb
==> chub_jmxtrans:
==> chub_jmxtrans: 108: execute "set correct jps alternative" do
==> chub_jmxtrans: 109:   command "update-alternatives jps --auto jps"
==> chub_jmxtrans: 110:   creates "/usr/bin/jps"
==> chub_jmxtrans: 111: end
==> chub_jmxtrans: 112:
==> chub_jmxtrans:
==> chub_jmxtrans: Compiled Resource:
==> chub_jmxtrans: ------------------
==> chub_jmxtrans: # Declared in /tmp/vagrant-chef/ac8c3f11f4d0fda7770beb101dfde37f/cookbooks/jmxtrans/recipes/default.rb:108:in `from_file'
==> chub_jmxtrans:
==> chub_jmxtrans: execute("set correct jps alternative") do
==> chub_jmxtrans:   action "run"
==> chub_jmxtrans:   retries 0
==> chub_jmxtrans:   retry_delay 2
==> chub_jmxtrans:   guard_interpreter :default
==> chub_jmxtrans:   command "update-alternatives jps --auto jps"
==> chub_jmxtrans:   backup 5
==> chub_jmxtrans:   creates "/usr/bin/jps"
==> chub_jmxtrans:   returns 0
==> chub_jmxtrans:   cookbook_name :jmxtrans
==> chub_jmxtrans:   recipe_name "default"
==> chub_jmxtrans: end
==> chub_jmxtrans:

ERROR: Chef::Exceptions::MetadataNotValid: Cookbook loaded at path(s) [/home/vagrant/chef/cookbooks/jmxtrans] has invalid metadata: The `name' attribute is required in cookbook metadata

Title says it all.

jmxtrans.sh uses env variable of JMXTRANS_OPTS for additional configuration of the JVM at runtime. There should be a way to configure this from the cookbook so that relevant properties can be passed along to jmxtrans at run time.

I am comfortable making a PR for this feature should we think it provides some value.

The jmxtrans-cookbook will be moved to jmxtrans project so that jmxtrans users can benefit from finding the cookbook in the project repositories. Please be aware of the move and make any necessary changes if required after the move.