jo-source / jo-widgets Goto Github PK

When adding a status bar to a workbench model, the status bar will not be shown 
under some circumstances

IKeyListener on IComponent

ITextAreaWidget to render multi line text's

In Jo-Widget's download area are rather old jars. They should be removed.

private final IUnit defaultUnit;

public HertzUnitProvider(final IUnit defaultUnit) {
    Assert.paramNotNull(defaultUnit, "defaultUnit");
    this.defaultUnit = defaultUnit;
}

@Override
public IUnit getUnit(final Long value) {
    if (value != null) {
        final IUnitSet unitSet = HertzUnitSet.instance();
        for (int i = unitSet.size() - 1; i >= 0; i--) {
            final IUnit unit = unitSet.get(i);
            if (validateUnit(value, unit)) {
                return unit;
            }
        }
    }
    return defaultUnit;
}

/**
 * Checks if the value can be displayed using the given unit and Double converter without loss of decimal places.
 *
 * @param value
 * @param unit
 * @return
 */
private boolean validateUnit(final Long value, final IUnit unit) {
    final IUnitConverter<Long, Double> unitConverter = new LongDoubleUnitConverter(unit);
    final IUnitValue<Double> unitValue = unitConverter.toUnitValue(value);

    final IConverterProvider converters = Toolkit.getConverterProvider();
    final IConverter<Double> converter = converters.getConverter(Double.class);
    if (unitValue.getValue().doubleValue() < 0.5
        || !converter.convertToObject(converter.convertToString(unitValue.getValue())).equals(unitValue.getValue())) {
        return false;
    }
    return true;
}

The source code of the third party modules (groupId "org.eclipse") should be 
provided in a maven-conform way. Example:
swt-carbon-macosx-3.6.2.jar, swt-carbon-macosx-3.6.2.pom, 
swt-carbon-macosx-3.6.2-sources.jar

This line throws the exception " 
org.jowidgets.tools.powo.WidgetAlreadyInitializedException: Widget is already 
initialized (was already added to a parent)"

SwingToJo.create(new JFrame());

This call results in two new instances of 
org.jowidgets.impl.widgets.basic.FrameImpl, the first FrameImpl creates its own 
window.

IBluePrintFactory should have methods:

//sets an new defaults initializer for type, existing will be removed 

setDefaultsInitializer(Class<? extends ISetupBuilder> type, IDefaultInitializer 
initializer)

//adds an defaults initializer for type, exististing initializers will be kept. 
All initializers will be invoked in the order they was added

addDefaultsInitializer(Class<? extends ISetupBuilder> type, IDefaultInitializer 
initializer)

What steps will reproduce the problem?
1. Implement an IInputContentContainer
2. Register an IValidateable with the register method
3. Change the validation result of the validatable
3. Fire a validation condition changed method on the validatable 
4. The input composites ValidationLabel does not update the validation state

What is the expected output? What do you see instead?

The label changes

What steps will reproduce the problem?
1. Create a combobox
2. Set it to editable = false
3. The combobox will be disabled
4. The value of the combobox can not be copied to the clippboard

What is the expected output? What do you see instead?

Idea:

Render comboboxes that are not editable with an text field that is not editable

See attached image and 
http://help.eclipse.org/helios/index.jsp?topic=/org.eclipse.platform.doc.isv/ref
erence/api/org/eclipse/jface/dialogs/MessageDialogWithToggle.html

The Test-Tool needs to know when an application is started/stopped to trigger 
its replay-thread.

What steps will reproduce the problem?
1. Implement an IInputContentContainer
2. Register an IValidateable with the register method
3. Change the validation result of the validatable
3. Fire a validation condition changed method on the validatable 
4. The input composites ValidationLabel does not update the validation state

What is the expected output? What do you see instead?

The label changes

What steps will reproduce the problem?
1. Open search
2. Pass following string " *" - whitespace is required


What is the expected output? What do you see instead?

java.lang.NullPointerException
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createContainsAnyPredicate(CriteriaQueryCreator.java:633)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createArithmeticFilterPredicate(CriteriaQueryCreator.java:444)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createArithmeticFilterPredicate(CriteriaQueryCreator.java:301)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createFilterPredicate(CriteriaQueryCreator.java:226)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createBooleanFilterPredicate(CriteriaQueryCreator.java:282)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createFilterPredicate(CriteriaQueryCreator.java:234)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createBooleanFilterPredicate(CriteriaQueryCreator.java:282)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createFilterPredicate(CriteriaQueryCreator.java:234)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createBooleanFilterPredicate(CriteriaQueryCreator.java:282)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createFilterPredicate(CriteriaQueryCreator.java:234)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.fillQuery(CriteriaQueryCreator.java:202)
    at org.jowidgets.cap.service.jpa.impl.query.CriteriaQueryCreator.createReadQuery(CriteriaQueryCreator.java:131)
    at org.jowidgets.cap.service.jpa.impl.SyncJpaReaderServiceImpl.read(SyncJpaReaderServiceImpl.java:71)
    at org.jowidgets.cap.service.impl.ReaderServiceAdapter.read(ReaderServiceAdapter.java:61)
    at sun.reflect.GeneratedMethodAccessor74.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.jowidgets.cap.service.hibernate.impl.CancelServicesDecoratorProviderImpl$CancelableInvoker.invoke(CancelServicesDecoratorProviderImpl.java:201)
    at org.jowidgets.cap.service.hibernate.impl.CancelServicesDecoratorProviderImpl$CancelableInvoker.access$300(CancelServicesDecoratorProviderImpl.java:139)
    at org.jowidgets.cap.service.hibernate.impl.CancelServicesDecoratorProviderImpl$CancelInvocationHandler.invokeAsyncSignature(CancelServicesDecoratorProviderImpl.java:134)
    at org.jowidgets.cap.common.tools.proxy.AbstractCapServiceInvocationHandler.invoke(AbstractCapServiceInvocationHandler.java:60)
    at com.sun.proxy.$Proxy21.read(Unknown Source)
    at sun.reflect.GeneratedMethodAccessor74.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.jowidgets.cap.service.jpa.impl.JpaServicesDecoratorProviderImpl$JpaInvocationHandler.invokeAsyncSignature(JpaServicesDecoratorProviderImpl.java:236)
    at org.jowidgets.cap.common.tools.proxy.AbstractCapServiceInvocationHandler.invoke(AbstractCapServiceInvocationHandler.java:60)
    at com.sun.proxy.$Proxy21.read(Unknown Source)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.jowidgets.cap.remoting.server.GenericRemoteMethod.invokeMethodOnService(GenericRemoteMethod.java:172)
    at org.jowidgets.cap.remoting.server.GenericRemoteMethod.invoke(GenericRemoteMethod.java:68)
    at org.jowidgets.cap.remoting.server.GenericRemoteMethod.invoke(GenericRemoteMethod.java:47)
    at org.jowidgets.invocation.service.server.impl.MethodImpl.invoke(MethodImpl.java:104)
    at org.jowidgets.invocation.server.impl.InvocationServerServiceRegistryImpl.onMethodInvocation(InvocationServerServiceRegistryImpl.java:75)
    at org.jowidgets.invocation.server.impl.InvocationServerMessageReceiver.onMessage(InvocationServerMessageReceiver.java:69)
    at org.jowidgets.message.impl.http.server.Connection.doRun(Connection.java:75)
    at org.jowidgets.message.impl.http.server.Connection.doRun(Connection.java:80)
    at org.jowidgets.message.impl.http.server.Connection.doRun(Connection.java:80)
    at org.jowidgets.message.impl.http.server.Connection.access$000(Connection.java:44)
    at org.jowidgets.message.impl.http.server.Connection$1.run(Connection.java:65)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:744)




What version of the product are you using? On what operating system?

OS: Windows 
<jowidgets.version>0.28.3</jowidgets.version>
<jocap.version>0.25.2</jocap.version>

Please provide any additional information below.

inputChanged(Object source) sets different objects as source.

What the name of you project? Title says jo-widget, first wiki page jowidgets.

I suggest to make it consistent. I know that this is a silly request, but I 
guess consistency is a good thing.

Widget to render tables

In Jo-Widgets gibt es im Interface IContainer die Methoden !layoutBegin() und 
!layoutEnd().

Diese sind für die Implementierung gegen SWT sind diese in !SwtContainer.java 
definiert als:

{{{
public void layoutBegin() {
    composite.setRedraw(false);
}
}}}

und 

{{{
public void layoutEnd() {
    composite.layout(true, true);
    composite.setRedraw(true);
}
}}}


Zweck dieser Operationen ist (nach meinem Verständnis) bei häufigen 
Änderungen von UI Komponenten
ein flackern zu vermeiden (durch das setRedraw(false)). 


Ein Performance-Bottleneck kann bei häufigem Aufruf der Methode layoutEnd() 
der Aufruf von
composite.layout(true, true) darstellen. Laut SWT Dokumentation bedeuten beide 
True Flags,
dass "Brute Force" alles komplett neu layout'ed wird, ohne Optimierung durch 
z.B. gecache'te Informationen: 
{{{
If the changed argument is true the layout must not rely on any information it 
has cached about its children.
If it is false the layout may (potentially) optimize the work it is doing by 
assuming that none of the receiver's
children has changed state since the last layout. If the all argument is true 
the layout will cascade down through
all child widgets in the receiver's widget tree, regardless of whether the 
child has changed size.
}}}
Wird layoutEnd häufig augerufen, kann dies zu einer "Trägheit" der 
betroffenen UI Teile führen.

Daher ist layoutBegin und layoutEnd nur dort zu verwenden, wo man sicher sein 
kann, dass es selten
aufgerufen wird bzw. wo keine negativen Auswirkungen auf die UI Performance zu 
befürchten sind.

Ein Vorschlag für eine API Änderung ist daher, neben der Methode 

{{{
void layoutEnd()
}}}


eine weitere 


{{{
void layoutEnd(boolean optimise)
}}}


einzuführen. Der Flag optimise gibt an ob auf Optimierungen beim layoutEnd 
zurückgegriffen werden kann. 

getParent() returns widgets than are neither an IWindowWidgetCommon nor an 
IChildWidget, so implementation returns null in some cases, even if all widgets 
was created with the widget api

TextFields must have the possibility to be prentated as password:

e.g. ******

When integrating Jo-Widgets into the application, I would like to be able to 
disable or explicitely enable the registration of the "Dynamic Perspective" to 
the list of available perspectives as this should be an optional feature.

Requirements:
- the registration of the "Dynamic Perspective" is per disabled (per default) 
and must be explicitely enabled (e.g. setting a property) if needed
OR
- there is a mechanism (e.g. setting a property) to disable the registration of 
the "Dynamic Perspective"

also a shutdown hook should be supported by WorkbenchToolkit

The SwingApplicationRunner calls a restricted method when 
`IApplicationLifecycle#finish` is called. This leads to an exception thrown 
when used in an unsigned webstart application (and the JVM process will not be 
terminated):
{{{
java.security.AccessControlException: access denied 
(java.lang.RuntimePermission accessDeclaredMembers)
    at java.security.AccessControlContext.checkPermission(Unknown Source)
    at java.security.AccessController.checkPermission(Unknown Source)
    at java.lang.SecurityManager.checkPermission(Unknown Source)
    at java.lang.SecurityManager.checkMemberAccess(Unknown Source)
    at java.lang.Class.checkMemberAccess(Unknown Source)
    at java.lang.Class.getDeclaredMethod(Unknown Source)
    at org.jowidgets.impl.swing.application.SwingApplicationRunner$1.finish(SwingApplicationRunner.java:70)
}}}

  private static final int FACTOR_GHZ = 1000000000;

  @Test
  public void testConvert1005GHzDouble() {
        final double value = 1.005; // eingegebener Wert
        final long baseValue = (long) (value * FACTOR_GHZ); // interner Wert
        final double convertedBack = (double) baseValue / FACTOR_GHZ;

        Assert.assertEquals(1005000000, baseValue); // java.lang.AssertionError: expected:<1005000000> but was:<1004999999>
        Assert.assertEquals(value, convertedBack, 0d); //java.lang.AssertionError: expected:<1.005> but was:<1.004999999>
  }

  @Test
  public void testConvert1005GHzBigDecimal() {
        final BigDecimal value = BigDecimal.valueOf(1.005);
        final BigDecimal baseValue = value.multiply(BigDecimal.valueOf(FACTOR_GHZ));
        final BigDecimal convertedBack = baseValue.divide(BigDecimal.valueOf(FACTOR_GHZ));

        Assert.assertEquals(1005000000, baseValue.longValue()); // kein AssertionError!
        Assert.assertEquals(value, convertedBack); // kein AssertionError!
  }

Containers should have the following methods:

List<IControl> getChildren();
boolean removeChild(IControl control);

I need the function getScreenSize().

I think, this feature would be properly positioned in 
org.jowidgets.api.toolkit.IToolkit 

.

Move all possible setups from common module to api module to reduce 
implementation effort of spi.

e.g. getForegroundColor() could be considered from api when creating an widget

Suggestion: add new enumeration class for special keys like F1, ESC etc. and 
add a new constructor for Accelerator.

ERROR_INFO type means Errors, where the user has not done anything wrong 
yet,(e.g hasn't done any input yet), but the input is nevertheless not valid. 

ERROR_INFO's could be rendered in a different color then (e.g. in Validation 
Label), so user will not be discouraged with errors before input already 
started.

After introduced the new type, the ValidationLabelWidget must be adopted for 
that, and MandatoryInfoValidator should use the new type.

the generated SWT textfield should be non-editable (it is...) AND non-enabled 
(it is NOT right now).

So the user would be aware directly that the field is immutable, even before he 
clicks 10 times into the field :-)

setMarkup on ToolBarItems

Would be nice if your jars could provide the OSGi meta-data. Ping me if you 
don't know how to do that.

setEnabled() and isEnabled() do not work for all widgets, so remove add them to 
the specific widgets where the methods do something

The resize listener for JFrame is not working properly, because it is called at 
the end of an resize event (and not continously while resizing).

Solution:
The ComponentListener (ComponentAdapter) has to be added to the ContentPane of 
the JFrame. This Listener will only receive resize events, because the 
ContentPane will never be moved relative to the JFrame.

Suggestion:

// in SwingComponent
final Component resizeListenerComponent;  // may be replaced by method
if (getUiReference() instanceof JFrame) {
    resizeListenerComponent = ((JFrame) getUiReference()).getContentPane();
}
else {
    resizeListenerComponent = getUiReference();
}
resizeListenerComponent.addComponentListener(new ComponentAdapter() {
    @Override
    public void componentResized(final ComponentEvent e) {
        componentObservable.fireSizeChanged();
    }
});

getUiReference().addComponentListener(new ComponentAdapter() {

    @Override
    public void componentMoved(final ComponentEvent e) {
        componentObservable.firePositionChanged();
    }
});

Please close if you disagree but could you switch to Git for your project?

If a beanInfo is set for create form the bean link panel renders the bean info 
in the same row like the form

Components must be able to request the focus

Until the default impl of the workbench does not support to unhide closed tabs, 
the default value should be changed to not closeable.

The Test-Tool needs getTitle() on Frame to generate IDs.

For ITree interface, only ITreeNodes can be observed.

The Tree itself should be observable too