Related to #4

There are some Kotlin resources

• Resource https://docs.gradle.org/current/userguide/troubleshooting.html#sec:troubleshooting_build_logic

From @JoaquimLey on November 20, 2017 14:49

https://developer.android.com/topic/instant-apps/getting-started/structure.html#basic-app

Copied from original issue: JoaquimLey/transport-eta-android#7

Display SMS-service-specific results to the screen, this way the user gets some actual value from the APP (ease of use)

Tasks ⚙

• List of SMS data separated by Station code

• Ability to easily make the same request

From @JoaquimLey on November 26, 2017 10:57

Here's the guide, still need to weigh the pros and cons

• https://antonioleiva.com/kotlin-dsl-gradle/

• https://handstandsam.com/2018/02/11/kotlin-buildsrc-for-better-gradle-dependency-management/

• https://medium.com/@vashisthg/migrating-from-groovy-to-kotlin-based-gradle-build-scripts-in-android-e16e0e4c42ff

Copied from original issue: JoaquimLey/transport-eta-android#10

Makes sense to add a scrolling behavior to the BottomNavigationBar for better visibility

Here's the link to the article: https://android.jlelse.eu/scroll-your-bottom-navigation-view-away-with-10-lines-of-code-346f1ed40e9e?__s=ep727fgnkqv7dsftb1ut

Tasks ⚙

• Copy The code into project

• Set the behavior to the HomeActivity's BottomNavigationBar

The code

class BottomNavigationBehavior<V : View>(context: Context, attrs: AttributeSet) : CoordinatorLayout.Behavior<V>(context, attrs) {

	override fun onStartNestedScroll(coordinatorLayout: CoordinatorLayout, child: V, directTargetChild: View, target: View, axes: Int, type: Int): Boolean {
		return axes == ViewCompat.SCROLL_AXIS_VERTICAL
	}

	override fun onNestedPreScroll(coordinatorLayout: CoordinatorLayout, child: V, target: View, dx: Int, dy: Int, consumed: IntArray, type: Int) {
		super.onNestedPreScroll(coordinatorLayout, child, target, dx, dy, consumed, type)
		child.translationY = max(0f, min(child.height.toFloat(), child.translationY + dy))
	}

	override fun layoutDependsOn(parent: CoordinatorLayout?, child: V, dependency: View?): Boolean {
		if (dependency is Snackbar.SnackbarLayout) {
			updateSnackbar(child, dependency)
		}
		return super.layoutDependsOn(parent, child, dependency)
	}

	private fun updateSnackbar(child: View, snackbarLayout: Snackbar.SnackbarLayout) {
		if (snackbarLayout.layoutParams is CoordinatorLayout.LayoutParams) {
			val params = snackbarLayout.layoutParams as CoordinatorLayout.LayoutParams

			params.anchorId = child.id
			params.anchorGravity = Gravity.TOP
			params.gravity = Gravity.TOP
			snackbarLayout.layoutParams = params
		}
	}
}

And on the BottomNavigationView XML add this attribute

app:layout_behavior="com.joaquimley.transporteta.<_SOME_PACKAGE_>.BottomNavigationBehavior"

Context

Although the project is quite small and it will be broken into smaller modules (all these help to make builds faster).

• There an interesting talk with some small tips that I would like to include

References

• https://www.youtube.com/watch?v=7ll-rkLCtyk

• https://github.com/jmslau/santa-tracker-android

Sending and receiving might be a good case for this #14

SmsController should maybe use this 🤔

Sources

• https://developer.android.com/topic/libraries/architecture/workmanager/

Other related, in-process background stuff:

• https://developer.android.com/reference/java/util/concurrent/Executors

• https://developer.android.com/training/multiple-threads/run-code

From @JoaquimLey on August 5, 2017 11:23

Source: https://developer.android.com/topic/libraries/support-library/preview/physics-based-animation.html#spring-animation

Copied from original issue: JoaquimLey/transport-eta-android#4

Currently, there is zero coverage.

Why

For the initial setup and basic functionally (mostly on stream), no tests were written, but the goal is to have a fully tested app. This will also enable the full power of having a CI/CD pipeline (#19).

Tasks ⚙️

• Initial setup (dependencies and example tests running)

• Instrumentation FavoritesFragment

• Unit tests for FavoritesViewModel

• Unit tests for SmsController

• Unit tests for SmsBroadcastReceiver

• Integration tests (UI -> ViewModel + ViewModel -> SMSController)

• Integrate with some codecov like service for overview

  • Be sure to properly configure (ignore unwanted files to provide accurate %)

Resources and references

• A nice gist on how to write good Unit tests https://github.com/dbacinski/Android-Testing-With-Kotlin/blob/master/docs/Unit-Testing-Introduction.md

• Spek http://spekframework.org/

• Kotlin: Using (Test) Robots to make Espresso (kotlin DSL) https://proandroiddev.com/kotlin-using-test-robots-to-make-espresso-8cec2d746973

Tasks ⚙️

• Send and receive service-specific SMS

• Broadcast the service-specific SMS to consumer

From @JoaquimLey on August 10, 2017 9:47

Send SMS request from app shortcut for favorite stations.

Copied from original issue: JoaquimLey/transport-eta-android#5

Already started building on stream14 and stream15

• FavoritesRepository Units tests

• FavoritesRepository implementation

• TransportRepository Units tests

• TransportRepository implementation

• TransportDataStore Unit testes

• TransportDataStore implementation

  • Should decide which source to pull data from/to
  • Gets the sources via DI
  • Check if data is expired/dirty and needs an update

Sources

• Shared preferences data source #17
  • Tests

Decide if SMS actions (requestEta/cancelEta) should come from the repository or the SmsController directly

Other refs: #12, #14

Reference

• https://medium.com/google-developers/livedata-with-snackbar-navigation-and-other-events-the-singleliveevent-case-ac2622673150

Some sources:

• https://blog.stylingandroid.com/ml-for-android-developers-part-1-2/

• https://www.youtube.com/watch?v=JnhW5tQ_7Vo&index=35&list=WL&t=0s

Ref. #53

Some nice status dashboard that can be shown on the stream

Context

• Viewers on the stream will have both an overview and might be a way to increase engagement (on stream and github too).

• This might help to get some contributions to this repository

• The work vs potential makes this an interesting thing to tackle early in the project too hence Priority - Medium

Some resources

• DataDog: https://www.datadoghq.com

• Geckoboard: https://try.geckoboard.com

• keen/dashboards: https://github.com/keen/dashboards (this one is interesting, might be able to add both GitHub as aswell twitch stuff at the same time 🤔)

• github-pr-triage: https://github.com/peterbe/github-pr-triage
  (this one is quite interesting, already hosted but only shows PRs so I need to host in on my own droplet, quite a winner for this use case)

Useful for running multiple UI tests.

Reference

• https://medium.com/stepstone-tech/android-test-orchestrator-unmasked-83b8879928fa

I tried to run this project but getting below error.

2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:16.151 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:16.152 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:40:21.171 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 249, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:40:21.171 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:21.171 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:21.172 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:40:26.191 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 257, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:40:26.191 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:26.191 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:26.192 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:40:31.211 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 265, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:40:31.213 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:31.213 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:31.214 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:40:33.465 3214-3214/? E/cutils-trace: Error opening trace file: Permission denied (13) 08-20 22:40:33.503 3214-3214/? E/memtrack: Couldn't load memtrack module (No such file or directory) 08-20 22:40:33.503 3214-3214/? E/android.os.Debug: failed to load memtrack module: -2 08-20 22:40:33.917 3233-3233/? E/cutils-trace: Error opening trace file: Permission denied (13) 08-20 22:40:33.955 3233-3233/? E/memtrack: Couldn't load memtrack module (No such file or directory) 08-20 22:40:33.955 3233-3233/? E/android.os.Debug: failed to load memtrack module: -2 08-20 22:40:35.530 3245-3245/? E/cutils-trace: Error opening trace file: Permission denied (13) 08-20 22:40:35.539 3248-3248/? E/cutils-trace: Error opening trace file: Permission denied (13) 08-20 22:40:35.580 3248-3248/? E/memtrack: Couldn't load memtrack module (No such file or directory) 08-20 22:40:35.580 3248-3248/? E/android.os.Debug: failed to load memtrack module: -2 08-20 22:40:35.596 3245-3245/? E/memtrack: Couldn't load memtrack module (No such file or directory) 08-20 22:40:35.596 3245-3245/? E/android.os.Debug: failed to load memtrack module: -2 08-20 22:40:36.241 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 273, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:40:36.242 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:36.242 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:36.242 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:40:41.263 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 281, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:40:41.263 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:41.264 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:41.264 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:40:46.292 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 297, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:40:46.293 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:46.293 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:46.293 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:40:51.312 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 305, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:40:51.313 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:51.313 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:51.314 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:40:56.343 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 313, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:40:56.343 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:40:56.343 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:40:56.344 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:41:01.361 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 321, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:41:01.362 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:41:01.362 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:41:01.363 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:41:06.388 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 329, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:41:06.388 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:41:06.388 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:41:06.389 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:41:17.555 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 337, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:41:17.555 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:41:17.555 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:41:17.555 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:41:22.571 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 345, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:41:22.572 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:41:22.572 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:41:22.572 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:41:27.590 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 353, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:41:27.591 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:41:27.591 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:41:27.591 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded 08-20 22:41:32.612 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord: Could not get audio input for session 361, record source 1999, sample rate 16000, format 0x1, channel mask 0x10, flags 0 08-20 22:41:32.614 2300-2397/com.google.android.googlequicksearchbox:search E/AudioRecord-JNI: Error creating AudioRecord instance: initialization check failed with status -22. 08-20 22:41:32.614 2300-2397/com.google.android.googlequicksearchbox:search E/android.media.AudioRecord: Error code -20 when initializing native AudioRecord object. 08-20 22:41:32.615 2300-2397/com.google.android.googlequicksearchbox:search E/ActivityThread: Failed to find provider info for com.google.android.apps.gsa.testing.ui.audio.recorded

Subtask of #69

Tasks ⚙

• Implement with SharedPreferences for first version

Add a task for automated screenshots

Context

• With this task, the PlayStore listing will be localized for each supported language/city

• This can be a simple step of the CI pipeline #19

References

• http://www.donnfelker.com/simplifying-internationalization-on-android/

Test class example:

@RunWith(AndroidJUnit4.class)
public class FirstScreenShootTest {

	@ClassRule
	public static final LocaleTestRule localeTestRule = new LocaleTestRule();

	@Rule
	public ActivityTestRule<SomeActivity> activityRule = new ActivityTestRule<>(SomeActivity.class);

	@BeforeClass
	public static void setupClass() {
		Screengrab.setDefaultScreenshotStrategy(new UiAutomatorScreenshotStrategy());
	}

	@AfterClass
	public static void tearDownClass() throws Exception {
                //		 Code executed after the last test method
	}


	@Before
	public void setup() {

	}

	@After
	public void tearDown() {

	}

	@Test
	public void testTakeScreenshot() {
		Screengrab.screenshot("file_name");

		onView(withId(R.id.fab)).perform(click());

		Screengrab.screenshot("after_click_screen_shot_file_name");
	}
}

Since the project will have (at least unit) tests. It makes sense to set up a CI server (also good for demo purposes).

Also look into Firebase test lab

Context

This way the builds will automatically run all the tests, build APKs, deploy to test lanes and to play store.
There are some good tools it makes sense to explore

• Bitrise.io https://www.bitrise.io/

• Travis https://www.travis-ci.org/

• CircleCi https://circleci.com/

There are some cool articles helping out with this:

• Bitrise: https://overflow.buffer.com/2018/02/01/setting-android-projects-bitrise-ci/?utm_content=buffer6ec60&utm_medium=social&utm_source=twitter.com&utm_campaign=buffer

  • https://github.com/bitrise-io/bitrise

• CircleCi (with Firebase test lab): https://medium.com/@ayltai/all-you-need-to-know-about-circleci-2-0-with-firebase-test-lab-2a66785ff3c2

  • https://proandroiddev.com/modular-and-dynamic-app-delivery-android-app-bundle-9bbfac814787

• Travis (make it fast): https://medium.com/zendesk-engineering/speeding-up-android-builds-on-travis-ci-1bb4cdbd9c62

From @JoaquimLey on November 20, 2017 14:49

https://android-developers.googleblog.com/2017/10/working-with-multiple-jobservices.html

Copied from original issue: JoaquimLey/transport-eta-android#6

Start building the domain layer so we can start integrating remote and local data layers without affecting the rest of the present code.

This way we can start extracting some of this logic out of the ViewModel.

This will greatly improve the way we cand o tests

This is a quick and easy way to remove boilerplate

Reference

• https://medium.com/thoughts-overflow/how-to-add-a-fragment-in-kotlin-way-73203c5a450b

This new RecyclerView adapter can remove a lot of boilerplate and give us changes for free, especially important for this project.

Resource

• https://medium.com/@trionkidnapper/recyclerview-more-animations-with-less-code-using-support-library-listadapter-62e65126acdb

See also

• #13
• #18

A simple way to demo integrating Google Assistant with apps

Reference

• https://blog.dialogflow.com/post/new-io18-features/

• https://developers.google.com/actions/

I/O Video

• https://www.youtube.com/watch?v=vOnStV8wJS8

https://github.com/JoaquimLey/bus-eta/blob/26ce1a7f4b2dff12c6efa2292531035e70bfc4ae/app/src/main/java/com/joaquimley/buseta/App.java#L22

From @JoaquimLey on November 23, 2017 15:30

https://github.com/airbnb/DeepLinkDispatch

Copied from original issue: JoaquimLey/transport-eta-android#8

Not for now, just to keep the reference

Context

In the future is more than likely that some cronjobs will run on the backend, this "service" provides a good and easy way to monitor the status of each cronjob.

• https://cronhub.io

With the current repeated names, it becomes really hard to import the correct one since some of these modules have dependencies btw'em.

E.g

• DomainDataFactory ->DomainDataFactory

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Launch the app. Wait until the loading of bus list finished.
2. Swipe to refresh.
3. While the loading view is still displaying, press the fab icon at the bottom right corner
4. App crashes.

Expected behavior
App should not crash

Smartphone (please complete the following information):

• Device: HTC one
• OS: Android 6.0

This is just visual candy to make it easier to see which version is

Part of the Jetpack #50

Reference

• https://blog.novoda.com/android-p-slices-missing-documentation-part-1/

Since I copied from the other project there might be some dependencies that are not being actually used

It's paramount that the crashes are correctly displayed.

Options

There are some obvious choices

• Fabric.io

• Directly migrate from ☝️ to Firebase

• Microsoft's AppCenter

No matter the tool the project goes with should be coupled with the same one used on #19, I'm initially inclined to Firebase due to the strong developer tools suite.

Due to changes with the introduction of the Domain layer, the FavoritesViewModel dependencies will be simple interfaces (UseCases and the model mapper).

This might make the tests easier

Reference

• https://medium.com/mindorks/light-camera-actions-6bc939abb401

• https://developers.google.com/actions/

• https://www.bignerdranch.com/blog/icing-on-the-slice/?__s=ep727fgnkqv7dsftb1ut

Updates

• https://developers.googleblog.com/2018/10/make-money-from-your-actions-create.html?linkId=57691314

Read also

• #52

Reference

• EmojiCompat guide → https://goo.gl/7bEoXB

• EmojiCompat sample app → https://goo.gl/7bEoXB

• Youtube video: https://www.youtube.com/watch?v=sYGKUtM2ga8

From @JoaquimLey on February 26, 2018 23:16

• Source: https://github.com/JakeWharton/RxBinding

Copied from original issue: JoaquimLey/transport-eta-android#12

Depends on versions.gradle task #10

Top level build.gradle

buildscript {
    ext.kotlin_version = '1.1.4-2'
    apply from: './versions.gradle'
    addRepos(repositories)
    dependencies {
        classpath deps.android_gradle_plugin
        classpath deps.kotlin.plugin
    }
}

allprojects {
    addRepos(repositories)
}

With all the new sugary things announced at I/O'18, this is the perfect playground project to test things.

Context

This will provide way cleaner APIs and dependencies, unifying the maven paths, testing the 28-alpha versions etc.

Tasks ⚙️

• Go to -> https://developer.android.com/jetpack/
• Migrate all the necessary dependencies being used
• Update and cleanup build.gradle, versions.gralde

UI 🎨

• Migrate app theme to Material theme

  • https://github.com/material-components/material-components-android/blob/master/docs/getting-started.md

  • style="@style/Widget.MaterialComponents.TextInputLayout.OutlineBox"

  • https://github.com/material-components/material-components-android/tree/master/demos

• Bottom sheet modal

  • https://medium.com/halcyon-mobile/implementing-googles-refreshed-modal-bottom-sheet-4e76cb5de65b

Moareee

These will have new separate issues.

• Want to try out the WorkManager to post sms tasks to the background

  • https://developer.android.com/topic/libraries/architecture/adding-components#workmanager

• Also look into the ThreadPool for other tasks:

  • https://developer.android.com/training/multiple-threads/create-threadpool#ThreadPool
    • See Also: https://developer.android.com/reference/android/app/IntentService

• Look into App bundle

  • https://developer.android.com/guide/app-bundle/build

Use Firebase

FCM:

• https://firebase.googleblog.com/2018/09/handle-fcm-messages-on-android.html?linkId=57036841

Since this project will mostly be developed on the stream makes sense to add each step (link) to the readme. Also, some reference to the stream helps

• Create changelog section

• Add the latest stream to the changelog section

• Add stream (and other social) links

In order to facilitate the user, we should add the ability to save favorite stations. Depends on #17

• Make it easy UX-wise to make these same favorite requests (MD2.0).

Tasks ⚙

• Convert to dynamic feature module

  https://proandroiddev.com/dynamic-feature-module-android-ondemand-module-android-app-bundle-ea0d872b32d

• Display fetched favorites on the list depends on -> #13

• Ability to add a favorite to the favorites list

• Ability to remove a favorite

• Instrumentation tests

• Unit tests

HomeActivity is currently responsible for requesting the necessary Android permissions, this is wrong.

Context

The idea is the HomeActivity should only be responsible for navigation.

Tasks

• Create a specific activity to request the permissions (since the app is unusable without), keeps the responsibilities simple.

Extract this code from HomeActivity

 /**
     * Runtime permission shenanigans
     */
    private fun hasReadSmsPermission(): Boolean {
        return ContextCompat.checkSelfPermission(this, Manifest.permission.READ_SMS) == PackageManager.PERMISSION_GRANTED &&
                ContextCompat.checkSelfPermission(this, Manifest.permission.RECEIVE_SMS) == PackageManager.PERMISSION_GRANTED &&
                ContextCompat.checkSelfPermission(this, Manifest.permission.SEND_SMS) == PackageManager.PERMISSION_GRANTED
    }

    private fun requestReadAndSendSmsPermission() {
        ActivityCompat.requestPermissions(this,
                arrayOf(Manifest.permission.SEND_SMS, Manifest.permission.READ_SMS, Manifest.permission.RECEIVE_SMS), SMS_PERMISSION_CODE)
    }

Pusher

• https://pusher.com/features

https://insert-koin.io/

https://github.com/InsertKoinIO/koin/tree/master/koin-projects/examples/android-mvvm

Why 🤔

• Since the original project has become quite stale and the idea now is to develop this with the Twitch Stream there is a need to do the initial setup again.

Tasks ⚙️

• Initial project setup

• Use versions.gradle configuration

•  Initial project scaffold

• Include initial dependencies (AAC/D2/ETC)

Related to #4

• Resource https://proandroiddev.com/speed-up-your-build-with-gradle-remote-build-cache-2ee9bfa4e18

See also: #23

Context

Improve the way ViewModels are instantiated (even with custom arguments/factory) the resource article has all the necessary steps.

Resource

• Hacking Architecture Components by using Kotlin: https://antonioleiva.com/architecture-components-kotlin/

Due to the introduction of the Domain layer, the current implementation makes no sense (directly leaking SmsController)

• Remove all of the SmsController related code

• Handle (and execute) UseCases

• Fix Unit tests