jodrack07 / todo-list-app Goto Github PK

Hello @joseph07-drack 👋 you did Amazing work 🥇 .

• Clean Code 👍 .
• Github workflow 👍 .

but I noticed that the live demo link is not working, there is a typo on the URL.

1. kindly fix that.

JEST TESTING REVIEW

First, I will say I like the way, you kept the code DRY and your use of desctructuring. Altogther, you have a great project 👍 . But I feel like you can use some better practices to deliver KISS and DRY codes. Below are the issues:

• The null input was not taken care of in the add method.
• Kindly try to keep it simple with remove testing code.

Code quality checking (Javascript Best practices, DRY, KISS and YAGNI)

• JavaScript Best Practices:
  - window.location.reload() is not a good practice, find a way to include the event.preventDefault() so that the page
  may not reload every time and an action get trigged. check (actions.js line 10 and line 27 and ./src/index.js line 72)
  - unused codes used not be part of the codebase, kindly remove the ./modules/todos.js file.
  - avoid using verbose code for code readability and maitenance. Kindly check this and refactor.

• DRY
  - I noticed there is localstorage snippet to store items that is repeated more than one time : (actions.js line 8, line 26 and line 32)

• KISS
  Everything is simple 👍

• YAGNI
  No unnecessary code complexy 👍