joebrentnall25 / punk-api Goto Github PK

// your code
useEffect(() => {
    getData(formatBeerName());
  }, [searchTerm, isHighAbv, isClassicRange, isAcidic]);

// using just the "required" dependencies (although you can add more)
useEffect(() => {
    getData(formatBeerName());
  }, [getData, formatBeerName]);

//your code 
const formatBeerName = () => {
    if (searchTerm !== "") {
      return (
        baseUrl +
        "beer_name=" +
        searchTerm.replace(" ", "_") +
        "&" +
        generateUrl()
      );
    } else {
      return baseUrl + generateUrl();
    }
  };

//switch the statement around, using a "guard clause" to leave the function asap
const formatBeerName = () => {
    if (searchTerm === "") {
      return baseUrl + generateUrl();
    }

    return (
      baseUrl +
      "beer_name=" +
      searchTerm.replace(" ", "_") +
      "&" +
      generateUrl()
    );
  };

// your code
.then((data) => {
  if (isAcidic) {
    const filteredData = data.filter((beer) => {
      return beer.ph < 4;
    });
    setBeers(filteredData);
  } else {
    setBeers(data);
  }
});

// we always do "setBeers" with some data, so we could remove that else
.then((data) => {
  if (isAcidic) {
    data = data.filter((beer) => {
      return beer.ph < 4;
    });
  }
  setBeers(data);
});