joewhite / dgrok Goto Github PK

The examples that come with the Object Pascal Handbook yield the following parse error

	Unrecognized compiler directive 'ZEROBASEDSTRINGS' (1)
		.\StringMetaTestForm.pas:651

The offending line in ObjectPascalHandbook/06/StringMetaTest/StringMetaTestForm.pas is
31:{$ZEROBASEDSTRINGS ON}

This example can be found here on github:
https://github.com/MarcoDelphiBooks/ObjectPascalHandbook/tree/master/06/StringMetaTest
ZEROBASEDSTRINGS is described here:
http://docwiki.embarcadero.com/RADStudio/Rio/en/Zero-based_strings_(Delphi)

Assuming that we need to add
_directiveTypes["ZEROBASEDSTRINGS"] = DirectiveType.Ignored;
to the TokenFilter constructor in TokenFilter.cs

The examples that come with the Object Pascal Handbook yield the following parse error

ObjectPascalHandbook/06/CharTest/CharTestForm.pas
35:{$HIGHCHARUNICODE ON}

This example can be found here on github:
https://github.com/MarcoDelphiBooks/ObjectPascalHandbook/tree/master/06/CharTest
HIGHCHARUNICODE is described here:
http://docwiki.embarcadero.com/RADStudio/Sydney/en/HIGHCHARUNICODE_directive_(Delphi)

Assuming that we need to add
_directiveTypes["HIGHCHARUNICODE"] = DirectiveType.Ignored;
to the TokenFilter constructor in TokenFilter.cs

Just change the following will solve the issue.

#region TypeDecl
AddRule(RuleType.TypeDecl, TokenSets.Ident.LookAhead, delegate

=>

#region TypeDecl
AddRule(RuleType.TypeDecl, delegate
{
return CanParseRule(RuleType.Ident) && !CanParseRule(RuleType.Visibility);
}, delegate

The examples that come with the Object Pascal Handbook yield the following parse error

Failing (1)
	Expected EqualSign but found ProcedureKeyword (1)
		.\NestedClass.pas:263

The Offending file is here on github?
https://github.com/MarcoDelphiBooks/ObjectPascalHandbook/tree/master/07/NestedTypes

Stripping down the code to this:

unit NestedClass;

interface

type
  TOne = class
  public
    type TInside = class
      type TInsideInside = class
      end;
    public
      procedure InsideHello;
    end;
  end;

end.

--- We still get the error

Failing (1)
	Expected EqualSign but found ProcedureKeyword (1)
		.\NestedClass.pas:145

Will need to study this some more

See: http://docwiki.embarcadero.com/RADStudio/Rio/en/Nested_Type_Declarations

I manually applied the pull request #2
Fix the wrong look-ahead for the TypeDecl rule #2
and it fixes the above issue ( Thanks tomalla5120x ! )