johnathanmiller / secure-env-php Goto Github PK

If you have only few arguments you can pass to functions, you should avoid array of options and use named, strict parameters.
If you need, as far as I checked, like 3 or 4 arguments for encrypt/decrypt functions, you should do 3 or 4 arguments instead of an array. Than you wouldn't need to check for isset of parameters, php would do it for you. And it would be more readable, less unneeded code

If you agree, I can make a pull request, if you don't want to change that yourself :)

Originally posted by @k0d3r1s in #1 (comment)

I read your example in medium but did not understand how it works at all. I encode successfully but I do not know how to use it in Laravel.

Just some thoughts for doing this:

• Have a KeyStorage interface with getSecretKey() method
• Let the user pass their KeyStorage object in the initialization

Going this route, you might also have an EnvStorage interface to allow for alternate ways of storing the encrypted environment variables. Implementing this might help keep away from dreaded major version releases.

Error on: johnathanmiller/secure-env-php/src/Parser.php on line 27

g is implicit with preg_replace() and can be removed to make the code functional again