Giter VIP home page Giter VIP logo

modssl's People

Contributors

johnsully avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

modssl's Issues

Is it possible to gracefuly handle ssl connection errors?

22520:M 25 Nov 2019 06:00:55.552 # WARNING: The TCP backlog setting of 511 cannot be enforced because /proc/sys/net/core/somaxconn is set to the lower value of 128.
22520:M 25 Nov 2019 06:00:55.552 # Server initialized
22520:M 25 Nov 2019 06:00:55.552 # WARNING you have Transparent Huge Pages (THP) support enabled in your kernel. This will create latency and memory usage issues with KeyDB. To fix this issue run the command 'echo never > /sys/kernel/mm/transparent_hugepage/enabled' as root, and add it to your /etc/rc.local in order to retain the setting after a reboot. KeyDB must be restarted after THP is disabled.
22520:M 25 Nov 2019 06:00:55.553 * Initializing SSL configuration
22520:M 25 Nov 2019 06:00:55.595 * Module 'modssl' loaded from /modssl/modssl.so
22520:M 25 Nov 2019 06:00:55.595 * Ready to accept connections
22520:M 25 Nov 2019 06:00:55.595   Thread 0 alive.
22520:M 25 Nov 2019 06:01:34.591 # SSL Negotiation unsuccessful due to Error: TLS alert received: Error encountered in /modssl/submodules/s2n/tls/s2n_alerts.c line 96 : TLS alert received
Segmentation fault

Compile Error

g++ -o modssl.so patch.o  ssl.o module.o -shared -lssl -lcrypto -Lsubmodules/s2n/build/lib/ -l:libs2n.a -L./ -lsubhook
/usr/bin/ld: .//libsubhook.a(subhook.c.o): relocation R_X86_64_PC32 against symbol `subhook_disasm_handler' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
Makefile:35: recipe for target 'modssl.so' failed
make: *** [modssl.so] Error 1```

A few questions

Hello @JohnSully, this is quite an impressive project!

I wonder what the Redis modules API should provide in order to let such a project to exist without the need of hot patching. And if, by providing such APIs, the rest would continue to work without issues across releases, no longe relying on low level details about the Redis implementation. I'll review the SSL PR with the idea to merge before Redis 6, however this experiment of yours kinda changes the landscape. During the Redis Conf there was a meeting where I actually suggested to go with the module approach, but we were not sure about how much viable and convenient it was, so many were against the idea. However this project of yours brings new insights into this approach. Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.