jolmari / netcore-wcf-service-proxy Goto Github PK

The console application is barely a working .NET Core application, it would be beneficial for demonstrative purposes to replace it with a full-fledged ASP.NET Core application.

Should replace the concrete object initialization logic in all of the projects with some sort of Dependency Injection pattern. Most likely the ASP.NET core built-in IoC is enough.

The solution needs multiple WCF endpoints to truly show an example of a flexible and generic proxy implementation. The proxy itself needs to evolve also to accomodate this change.

ASP.NET Core application project relies on the full 4.6 framework. Figure out a way to drop reliance on System.ServiceModel and migrate to use only the .NET Core 2 framework.

• Proxy call to a service that requires authentication

• Remove need to instantiate proxies

Here i have 2 concerns.

1. Why we are creating instances using new? Can we register it by dependency injection and inject the IWcfProxy in the constructor.

  private readonly IWcfProxy<IPersonService> clientProxy;

        public PersonServiceWrapper(string endpointUrl)
        {
            clientProxy = new WcfProxy<IPersonServiceChannel>(endpointUrl);
        }

public CountryServiceWrapper(IWcfProxy<ICountryServiceChannel> proxy)
        {
            clientProxy = proxy;
        }
        
 services.AddScoped<ICountryServiceWrapper>(provider => new CountryServiceWrapper(endpointsConfig.CountryService));
            services.AddScoped<IPersonServiceWrapper>(provider => new PersonServiceWrapper(endpointsConfig.PersonService));

2. Another question is can we use the singleton registration for the WcfProxy class?

services.AddSingleton<IWcfProxy<ICarrierOperationsService>>(service =>
               new WcfProxy<ICarrierOperationsServiceChannel>(service
                   .GetRequiredService<IOptions<ServiceEndpointConfiguration>>().Value.CarrierOperationsService));

When authentication and endpoint URL based client creation is implemented, should store the necessary data in environment based config files.

Usernames & Password have to be stored in a secure location, not in the repository.