Giter VIP home page Giter VIP logo

Comments (6)

jonatanklosko avatar jonatanklosko commented on September 24, 2024 3

Nono, my point is that you can do this:

hooks/useConfirm.js

export default function useConfirmCustom() {
  const confirm = useConfirm();

  return useCallback((...args) => {
    return confirm(...args).then(() => true).catch(() => false);
  }, [confirm]);
}

components/MyComponent.js

import useConfirm from "../hooks/useConfirm";

function MyComponent(props) {
  const confirm = useConfirm();

  const handleClick = async () => {
    const consent = await confirm({ title: "Are you a duck?" });
    if (!consent) return;
    console.log("you're a duck");
  };

  return (...);
}

I think this kind of customization can be left to the user.

from material-ui-confirm.

moomoolive avatar moomoolive commented on September 24, 2024 2

Can confirm that this works. Thanks for all the help

from material-ui-confirm.

jonatanklosko avatar jonatanklosko commented on September 24, 2024

You should be able to create a simple wrapper to achieve that behaviour, try something like this:

function useConfirmCustom() {
  const confirm = useConfirm();

  return useCallback((...args) => {
    return confirm(...args).then(() => true).catch(() => false);
  }, [confirm]);
}

You can then put it into a file and even import as useConfirm in your components.

It's been a while, so let me know if I miss something :)

from material-ui-confirm.

moomoolive avatar moomoolive commented on September 24, 2024

That's true I could do that, but I'd have to create a function like that in every component that uses it (which would be a little tedious). Or am I missing something?

Also, this whole proposed change could be simply made as an option called returnsBool or something

confirm({ title: "Are you a duck?", returnsBool: true });

from material-ui-confirm.

moomoolive avatar moomoolive commented on September 24, 2024

Ha! Okay I tried that initially without useCallback (I'm relatively new to react)

Okay will try that out

from material-ui-confirm.

wladimir-k-m avatar wladimir-k-m commented on September 24, 2024

If anyone finds this info, keep in mind that the suggestion proposed by @jonatanklosko doesn't really solve the issue since confirm does not resolve nor reject when the user clicks outside of the dialog to dismiss it. In this case the await hangs indefinitely. This obviously is an issue if you have to reset some state after the await.

from material-ui-confirm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.