jonathanchu / atom-one-dark-theme Goto Github PK

It's more better when echo area will change the argument's font colour.

This makes it difficult to clearly see level 1 topics when there are links under them.
Even worse, the link face is bold while org-level-1 is not, so links stand out more than the headers.
This is not a bug but it would be nice to adjust the colors so that it's easier to see level 1 headers among links.

Unmatched parentheses, braces, and brackets in the editor turn black and are as good as invisible against the background. This makes it extremely hard to catch these errors and frequently leads to confusion when the syntax checker is complaining about unmatched braces. See the following screenshot for an example (there's a closing parenthesis immediately following the comma):

If this is due to the emacs rainbow parens and out of your hands, then I apologize, but if it's something that can be handled on your end, it'd be great to see a different coloration for unmatched parens, brackets, and braces.

First thank you for the awesome work bringing this great them to Emacs!

My setup: Ubuntu 20.10, Emacs 28 snapshot, Doom Emacs latest.

Issue:
After turning on vterm in doom emacs init file and building the module, everything works. I launched IPython 7.16 in a vterm buffer. The line numbers of input and output are totally merged with the dark background and invisible. This is kind of inconvenient. Switching to doom-one theme line numbers are good.

Please see the screenshot attached.

atom-one-dark:

doom-one:

Here are a couple of screenshots that showcases the highlights in ediff. They are sadly non-consistent with the atom-one-dark colourscheme, and appears to be rather unreadable.

My fixes

I have spent some time to experiment with the most opitmal colours, if I may kindly suggest:

  (ediff-fine-diff-A    ((t (:background "#885555"))))
  (ediff-fine-diff-B    ((t (:background "#558855"))))
  (ediff-fine-diff-C    ((t (:background "#555588"))))
  (ediff-current-diff-A ((t (:background "#663333"))))
  (ediff-current-diff-B ((t (:background "#336633"))))
  (ediff-current-diff-C ((t (:background "#333366"))))
  (ediff-even-diff-A    ((t (:background "#181a1f"))))
  (ediff-even-diff-B    ((t (:background "#181a1f"))))
  (ediff-even-diff-C    ((t (:background "#181a1f"))))
  (ediff-odd-diff-A     ((t (:background "#181a1f"))))
  (ediff-odd-diff-B     ((t (:background "#181a1f"))))
  (ediff-odd-diff-C     ((t (:background "#181a1f"))))

Here's how it looks like afterwards:

I've followed the instruction in the README.md and this is what i get

I'm reposting this from the company-mode issues tab. However, per the title of this inquiry, the drop-down menu has an unpleasant aesthetic. Previously in my myinit.org, I incorporated this string of code to change the color scheme for company, which according to the EmacsWiki: Company-Mode adjusts the color scheme for dark backgrounds (I have removed this portion of code from myinit.org):

(require 'color)
(let ((bg (face-attribute 'default :background)))
(custom-set-faces
 `(company-tooltip ((t (:inherit default :background ,(color-lighten-name bg 2)))))
 `(company-scrollbar-bg ((t (:background ,(color-lighten-name bg 10)))))
 `(company-scrollbar-fg ((t (:background ,(color-lighten-name bg 5)))))
 `(company-tooltip-selection ((t (:inherit font-lock-function-name-face))))
 `(company-tooltip-common ((t (:inherit font-lock-constant-face))))))

However, since following this block of code, my emacs has a strange appearance now:

I'm currently using the Atom-One-Dark-Theme, and it incorporates its own tooltip theme. However, it will not change the tooltip/drop-down menu to the proper colors. Here is the following code in the atom-one-dark-theme.el:

;; company-mode
  `(company-tooltip ((t (:foreground ,atom-one-dark-fg :background ,atom-one-dark-bg-1))))
  `(company-tooltip-annotation ((t (:foreground ,atom-one-dark-mono-2 :background ,atom-one-dark-bg-1))))
   `(company-tooltip-selection ((t (:foreground ,atom-one-dark-fg :background ,atom-one-dark-gray))))
   `(company-tooltip-mouse ((t (:background ,atom-one-dark-gray))))
   `(company-tooltip-common ((t (:foreground ,atom-one-dark-orange-2 :background ,atom-one-dark-bg-1))))
   `(company-tooltip-common-selection ((t (:foreground ,atom-one-dark-orange-2 :background ,atom-one-dark-gray))))
  `(company-preview ((t (:background ,atom-one-dark-bg))))
  `(company-preview-common ((t (:foreground ,atom-one-dark-orange-2 :background ,atom-one-dark-bg))))
  `(company-scrollbar-fg ((t (:background ,atom-one-dark-mono-1))))
  `(company-scrollbar-bg ((t (:background ,atom-one-dark-bg-1))))

Sorry if there's some ambiguity in this post; I'll try to clear out any questions that you might have.

atom-one-dark-theme isn't available on melpa-stable. Can you make this theme available on melpa-stable?

Hello @jonathanchu, thank you for this package.

I have installed and loaded it using use-package. When using it, I have noticed that the syntax highlighting looks different from the One Dark theme from Atom.

On the left I have a freshly installed Atom with some C code opened. On the right I have Emacs with the atom-one-dark-theme loaded, displaying the same code. As you can see, the syntax highlighting is very different.

I am not sure if it's a bug, or if I messed up something installing it... I'd appreciate any help.

Many thanks

Hi @jonathanchu

I am seeing multiple errors after I have updated to the latest version of atom-one-dark-theme from MELPA (20180116.1024)

Representative chunk from the errors are, but they occur whenever I change buffer

Unable to load color "#282C34"
Invalid face reference: nil [75 times]

I do not see any issues with the colors used across environments (mu4e, org-mode, magit, ESS and others) but an annoying side-effect is that emacs has to re-draw all buffers after each switch, so I am disabling the theme for now.

I am on

GNU Emacs 25.3.3 (x86_64-apple-darwin13.4.0, Carbon Version 157 AppKit 1265.21) of 2017-09-28

Thanks
-Ioannis

Hi, I'm new to emacs.

I've installed the theme and activated it by selecting Options → Customize Emacs → Custom Themes > atom-one-dark on the menu.

But my interface looks like this:

I'm using iTerm (build 33.0) on Mac, terminal type is xterm-256color and emacs version is 26.2

Awesome theme, thanks! I've got one problem. After load-themeing the theme, it doesn't set linum colors so the linum bar is left with its colors from my old theme.

Just wanted to say thank you for both this and the atom-one-light-theme. I was trying to set up a fairly clean site theme that honored prefers-color-scheme and since I used Atom I thought those colors would be ideal. Your two themes for emacs were the first ones I found with the hex-code.

Hi, I tried the theme on my config and it's all fine except for the width of the company frontend (look at the image). I tried to modify this manually but I couldn't figure out how to set automatically the same width for all the results.
Thanks

Seems like the #282C34 color isn't rendering properly. Haven't been able to figure out what might be the cause, but it's rendering as a vibrant blue tone:

Here's a shot of the hex colors rendering inline:

Not getting any errors in the output either.

Emacs 25.3.1
Atom One Dark 0.4.0
Iterm2 Build 3.1.5

Context: I'm running Ubuntu in WSL on Windows 10. Using Emacs through the terminal (Fish, if it changes anything).

The problem:
When running emacsclient, the background is incorrectly colored blue rather than the correct background color, which in this case would be to use the terminal's background color. The issue only occurs when running that one command (it works fine if I start it with emacs), and it does not seem to affect any other themes. I'm not really sure what is to blame here or whether it's on your end or mine, but considering it seems to only affect this theme, I thought I would raise this issue to at least see if you could offer any insights.

Please see the attached images for details. I'd be happy to provide you with more info if you let me know what you need.
One dark run with the emacs command

One dark run with the emacsclient command. Background is solid blue.

Tomorrow night theme run with the emacsclient command. Background is transparent (same color as the terminal).

EDIT:
This bit of code in my config file might be relevant, though I did try disabling it and restarting the server to no effect. It is run as a 'window-setup-hook.

(defun on-after-init()
  (unless (display-graphic-p (selected-frame))
  (set-face-background 'default "unspecified-bg" (selected-frame)))))

As reported by @feifanzhou:

The faces for latex are not customised properly, which results in this:

Same thing in atom:

Hi,

I have just tried to install the atom-one-dark-theme via M-x package-install.
This resulsts in the following error:

Leaving directory `/home/moreek/.emacs.d/elpa/atom-one-dark-theme-20150806.2117'
Compiling file /home/moreek/.emacs.d/elpa/atom-one-dark-theme-20150806.2117/atom-one-dark-theme-pkg.el at Fri Oct  2 13:15:38 2015
Entering directory `/home/moreek/.emacs.d/elpa/atom-one-dark-theme-20150806.2117/'
Compiling file /home/moreek/.emacs.d/elpa/atom-one-dark-theme-20150806.2117/atom-one-dark-theme.el at Fri Oct  2 13:15:38 2015
atom-one-dark-theme.el:48:1:Error: Symbol's value as variable is void: atom-one-dark-colors-alist

Did I overlook something?

Thanks
~ Moritz

Thsi can be fixed with adding company-tooltip-annotation-selection face, that combines the annotation foreground and selection background color:

   `(company-tooltip-annotation-selection ((t (:foreground ,atom-one-dark-mono-2 :background ,atom-one-dark-gray))))

What type of font is this?

While editing Javascript/Typescript files (JS, JSX, TS, TSX), in RXJS, Web-mode, Tide-mode, I happened to spot some differences:

VSCode (Atom One Dark Theme) shows:

While in Emacs:

Another example:

VSCode:

Emacs:

While I'd love to help, I feel a bit lost on what I should do into the theme file to match this colors.

Any help?

Hey man, thanks for your great work.

I'm using GNU Emacs 27.0.50 (built from source) on Ubuntu 16.04.

For faces like font-lock-comment-face where :slant italic is set, the foreground and background colors are reversed. For example, if :foreground ,atom-one-dark-fg :background ,atom-one-dark-bg :slant italic is set, actually foreground will be atom-one-dark-bg and background will be atom-one-dark-fg.

From the doc, slant seems to trigger some terminal features.

I changed :slant italic to :slant ,(if (display-graphic-p) 'italic 'normal) and things work well in the terminal. Haven't tried it in GUI since I'm working via ssh.

Lack knowledge on this part and would be great if you could explain this.

The screenshot in the README looks to be about 5 years old and different from what the theme looks like now.

Could you please specify the license used for this package?

Assuming that you want to release under "the GPL v3 or any later version", the best way to do that would be to add this permission statement to the library header:

;; This file is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation; either version 3, or (at your option)
;; any later version.

;; This file is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
;; GNU General Public License for more details.

;; You should have received a copy of the GNU General Public License
;; along with this program.  If not, see <http://www.gnu.org/licenses/>.

Also consider adding a LICENSE file containing the text of the GPL-3. You could add just that file without also adding the above persmission statement, but if you do that, then the "or (at your option) any later version" bit won't be known. So I recommend that you add both the actual license and the permission statement.

If you find the permission statement to be too noisy, then you could instead add one of these following lines to the header. If you do that, then it becomes more important to also add the LICENSE file - a judge might decide that such a line by itself is not sufficient. Still, adding just such a line is better than not specifing the license at all.

;; License: GNU General Public License version 3, or (at your option) any later version
;; License: GNU General Public License version 3, or any later version
;; License: GNU GPL version 3, or (at your option) any later version
;; License: GPL version 3, or (at your option) any later version
;; License: GPL version 3, or any later version
;; License: GPL v3, or (at your option) any later version
;; License: GPL v3, or any later version
;; License: GPL-3+

Hi,

I was browsing through the source code of one-dark-syntax and I couldn't find the following colors that have been used in atom-one-dark-theme:

https://github.com/jonathanchu/atom-one-dark-theme/blob/master/atom-one-dark-theme.el#L22
https://github.com/jonathanchu/atom-one-dark-theme/blob/master/atom-one-dark-theme.el#L23
https://github.com/jonathanchu/atom-one-dark-theme/blob/master/atom-one-dark-theme.el#L36
https://github.com/jonathanchu/atom-one-dark-theme/blob/master/atom-one-dark-theme.el#L37

Is it the case that I wasn't able to find these colors in the one-dark-syntax repo or did you use these colors independently?

Thanks,
sixpointzero

In VSCode one dark pro theme, both variable references and function call are highlighted, in coral red and blue respectively. In Emacs, neither is highlighted. While based on my use experience, it may be better to highlight function call in blue only, but leave variable reference not highlighted in plain white. Is it possible to implement? Thank you.

I was trying to install with package-install and package-list-packages. Both times I get the same error:

Wrong Argument Type: stringp, 47

Not sure if this is an issue with the theme or what, but thought I would check to see.

I had a question about the Emacs screenshot in the readme file.

How did you achieve the look and feel of Emacs on OSX?