jonathanchun / midiutil Goto Github PK

What steps will reproduce the problem?
1. Try to add many beats to track by addNote will generate this error:

"midiutil\MidiFile.py", line 619
    self.MIDIEventList.sort(lambda x, y: int( 1000 * (x.time - y.time)))
TypeError: comparison function must return int, not long

2. May be only Win7 issue?
3. Ive fixed it changing line 619 (and 385 and 411 for thet matter):

self.MIDIEventList.sort(lambda x, y: cmp(x.time*1000 , y.time*1000))

What is the expected output? What do you see instead?
Not to see the error, with the fix above no more problems encoutered

What version of the product are you using? On what operating system?
Version 0.89

Please provide any additional information below.
Thanks for sharing your excellent work!

Hi,

I'm using Python 3, and there's an issue with the use of struct.pack() in 
MIDIHeader. Any help would be greatly appreciated. Thanks!

---

Traceback (most recent call last):
  File "I:/pm/start.py", line 299, in <module>
    pm = PerpetualMotion()
  File "I:/pm/start.py", line 98, in __init__
    self.score = MIDIFile(9)
  File "I:\pm\midiutil\MidiFile3.py", line 695, in __init__
    self.header = MIDIHeader(numTracks)
  File "I:\pm\midiutil\MidiFile3.py", line 649, in __init__
    self.headerString = struct.pack('cccc','M','T','h','d')
struct.error: char format requires a bytes object of length 1

What steps will reproduce the problem?
1. Install your code
2. copy your example into a file
3. run it

What is the expected output? What do you see instead?
Traceback (most recent call last):
  File "miditest.py", line 7, in <module>
    MyMIDI = MIDIFile(1)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/site-packages/midiutil/MidiFile3.py", line 695, in __init__
    self.header = MIDIHeader(numTracks)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.3/lib/python3.3/site-packages/midiutil/MidiFile3.py", line 649, in __init__
    self.headerString = struct.pack('cccc','M','T','h','d')
struct.error: char format requires a bytes object of length 1


What version of the product are you using? On what operating system?
Current version, OSX ML

The documentation would make it seem like you can specify any number for 
"param1" in midi.addControllerEvent.

Attempting to add a controller event with paramValue > 255 results in the 
following error:

File "/Library/Python/2.7/site-packages/midiutil/MidiFile.py", line 540, in 
writeEventsToStream
    self.MIDIdata = self.MIDIdata + struct.pack('>B',event.paramerter1)
struct.error: ubyte format requires 0 <= number <= 255

Would be great if we could either extend the lib to support 14-bit messages 
like Pan and Pitch-Wheel. Or maybe there's another way to specify these 
messages and I'm missing something ...