jonathanstark / fastactive Goto Github PK

This is a great concept and thank you sharing your code.

I was hoping to use something like this on my jqueryui tabs. On a mobile device, there is an delay when you tap the tab before it applies the class "ui-state-active" so the tab looks slow to become active.

I tried FastActive, but the active class doesn't get removed when you have tabs that are collapsable like in this example http://jqueryui.com/tabs/#collapsible.

The first time I click a tab, the active class is applied. The next time I click the tab to collapse it, the active class is still applied. So in my case the tab would stay highlighted even when it shouldn't be.

Do you know of anyway for this to work with things that need to be toggled like the collapsable tabs?

Thanks for any help you can provide?

Hey there, I added support for adding to an element with a certain class name instead of just a tag name

changed if (targetTagNames.indexOf(e.target.tagName) > -1) {

to

if (targetTagNames.indexOf(e.target.className) > -1 || targetTagNames.indexOf(e.target.tagName) > -1) {

Just a quick little fix that may be useful to others, your script was very helpful!

I'm excited to use FastActive, as I think it's just the right way to handle the tap/delay issue: simply.

So far though when I try to implement it, the active class gets added to an a element, but it stays there pretty much for good. It will sometimes get removed on subsequent taps/touches, but it's random.

I expected the active class to only remain while the link was being touched. Is that a correct assumption?

I've been testing this on my iPhone 4S/iOS7/Safari, Chrome.

Example: http://codepen.io/FStop/pen/cuokl

Full pen link for easier mobile access: http://codepen.io/FStop/full/cuokl

I've also tested in Codepen's "debug" mode, which takes it out of an iframe and makes it into a plain old web page, just in case that had anything to do with it. Doesn't make a difference.

Am I an idiot (separate question, really) and missing something simple in the setup?