Hi @jonnitto, thanks for the package 😉

I was trying to switch my Neos installation to production context and received the following error message. Not sure if it's an error in my Neos installation or from "prettyembedvideoplatforms". Also reinstalling the "prettyembedvideoplatforms" package didn't help. Maybe you can shed some light on this issue?

FLOW_CONTEXT=Production ./flow
Neos 8.3.9 ("Production" context)
usage: ./flow <command identifier>

See "./flow help" for a list of all available commands.

The given class "Jonnitto\PrettyEmbedHelper\Service\ImageService" is not a registered object.

  Type: Neos\Flow\SignalSlot\Exception\InvalidSlotException
  Code: 1245673367
  File: Packages/Framework/Neos.Flow/Classes/SignalSlot/Dispatcher.php
  Line: 171

Open Data/Logs/Exceptions/202401161754425ff35d.txt for a full stack trace.

Here is the exceptions log.

Exception #1245673367 in line 44 of /Users/foo/path/to/Neos/Data/Temporary/Production/Cache/Code/Flow_Object_Classes/Neos_Flow_SignalSlot_SignalAspect.php: The given class "Jonnitto\PrettyEmbedHelper\Service\ImageService" is not a registered object.

17 Neos\Flow\SignalSlot\Dispatcher::dispatch("Neos\Flow\Persistence\Doctrine\PersistenceManager", "allObjectsPersisted", array|0|)
16 Neos\Flow\SignalSlot\SignalAspect_Original::forwardSignalToDispatcher(Neos\Flow\Aop\JoinPoint)
15 Neos\Flow\Aop\Advice\AbstractAdvice::invoke(Neos\Flow\Aop\JoinPoint)
14 Neos\Flow\Persistence\Doctrine\PersistenceManager::emitAllObjectsPersisted()
13 Neos\Flow\Persistence\Doctrine\PersistenceManager_Original::persistAll()
12 Neos\Flow\Package::Neos\Flow\{closure}(Neos\Flow\Cli\Request, Neos\Flow\Cli\Response, Neos\Flow\Command\HelpCommandController, "Neos\Flow\Mvc\Dispatcher::afterControllerInvocation")
11 Closure::__invoke(Neos\Flow\Cli\Request, Neos\Flow\Cli\Response, Neos\Flow\Command\HelpCommandController, "Neos\Flow\Mvc\Dispatcher::afterControllerInvocation")
10 call_user_func_array(array|2|, array|4|)
9 Neos\Flow\SignalSlot\Dispatcher::dispatch("Neos\Flow\Mvc\Dispatcher", "afterControllerInvocation", array|3|)
8 Neos\Flow\Cli\Dispatcher_Original::emitAfterControllerInvocation(Neos\Flow\Cli\Request, Neos\Flow\Cli\Response, Neos\Flow\Command\HelpCommandController)
7 Neos\Flow\Cli\Dispatcher_Original::dispatch(Neos\Flow\Cli\Request, Neos\Flow\Cli\Response)
6 Neos\Flow\Cli\CommandRequestHandler::Neos\Flow\Cli\{closure}()
5 Closure::__invoke()
4 Neos\Flow\Security\Context_Original::withoutAuthorizationChecks(Closure)
3 Neos\Flow\Cli\CommandRequestHandler::handleRequest()
2 Neos\Flow\Core\Bootstrap::run()
1 require("/Users/foo/path/to/Neos/Packages/Framework/Neos.Flow/Scripts/flow.php")

My composer version

composer -V
Composer version 2.6.6 2023-12-08 18:32:26

Composer.json require entry

"jonnitto/prettyembedvideoplatforms": "^3.2"

The autoplay function on mobile devices does not work with Firefox
Firefox blocks all autoplay videos with sound.
To be sure Firefox settings are not the problem I set the settings from Firefox to "Allow Audio and Video"

For reference:
https://codepen.io/nagasai/pen/mdEZabp
a native implementation was working with autoplay on my smartphone with firefox.

I also tested Safari, Chrome and Samsung Browser. No Problem

Information
This bug appears only on smartphones. The error does not appear in compatibility mode.

Smartphone (please complete the following information):

• Device: Samsung Galaxy Note 20
• OS: Android 13
• Browser: Firefox
• Version 118.2.0

I am a fan of using youtube-nocookie.com, but currently I am running into an issue, that it is not possible to pass the parameter "&autoplay=1".

So a user needs to click two times to start a video.

Demo url: with some other parameters, which work (except of autoplay): https://www.youtube-nocookie.com/embed/vwq9_rO28us?&autoplay=1&start=41&end=56&fs=0&controls=2&modestbranding=1&playsinline=1&rel=0&showinfo=0

Describe the solution you'd like
If I click the preview Image, the iframe which will be then load, should automatically start.

Describe alternatives you've considered
have an option to switch to the default youtube url, if the video has to load automatically. (maybe the consent element has to be shown then #gdpr, if no consent has given before via cookie)

Hi jonnitto,

thank you for this nice plugin!

Embedding a portrait Youtube video lead to an 500 error.

According to call stack

237 Neos\Eel\CompilingEvaluator_Original::evaluate("Jonnitto.PrettyEmbedHelper.paddingTop(this.ratio || this.force16to9)", Neos\Eel\ProtectedContext)
236 Neos\Eel\Utility_Original::evaluateEelExpression("${Jonnitto.PrettyEmbedHelper.paddingTop(this.ratio || this.force16to9)}", Neos\Eel\CompilingEvaluator, array|37|)

It looks like the bool false gets passed to paddingTop https://github.com/jonnitto/Jonnitto.PrettyEmbedHelper/blob/master/Classes/Eel/Helper.php#L25

And paddingTop doesn't handle this case, casts false to 0 and triggers Division by zero.

Is this a bad configuration or a bug?

Config:

  PrettyEmbedVideoPlatforms:
    defaults:
      lightbox: false
      preserveAspectRatio: false
      force16to9: false

Thank you very much!