jonpsmith / efschemacompare Goto Github PK

Hi.

Thank you for EfSchemaCompare.

If I have a database table with two foreign keys which have different cascade delete actions, CompareEfWithDb will return errors.

This is happening because when the cascade delete actions are checked, the code arbitrarily picks up the mismatched value, specifically for many-to-one and one-to-many relationships.

See

I've found that when a DbContext has mappings to a class in the same assembly, which is a nested class, then the comparer thinks the type is defined in another assembly.

Making the classes not nested is the obvious solution, but that would be... not easy.

Hi,

I ran into minor bug in EfCore.SchemaCompare 5.1.4 version (latest).

Setting default schema in DbContext to same value as default database schema (most likely dbo) results in incorrect comparison. This then most probably results in errors like NOT IN DATABASE: Entity 'Author', table name. Expected = dbo.Authors

Reproducing it is easy. Add modelBuilder.HasDefaultSchema("dbo"); to BookContext and most unit tests will fail.

The main issue is in methods that generates table names:

• FormSchemaTableFromModel - generates dbo.Author because we had explicitly specified dbo schema
• FormSchemaTableFromDatabase - generates Author because table.Schema == defaultSchema

Hi @JonPSmith
I have the following TypeLoadException

since I don't have resharper to run the unit tests, can you fix it?
I already tried as follow

but then it complains that the column is missing.
Not sure why